Skip to content

fix(#288): parse automation interval strings#326

Merged
SamXop123 merged 1 commit into
SamXop123:mainfrom
Shreya-nipunge:fix-288-parse-automation-interval-strings
Jul 5, 2026
Merged

fix(#288): parse automation interval strings#326
SamXop123 merged 1 commit into
SamXop123:mainfrom
Shreya-nipunge:fix-288-parse-automation-interval-strings

Conversation

@Shreya-nipunge

Copy link
Copy Markdown
Contributor

Description

Fixes themeAutomation.checkIntervalMinutes sanitization so numeric strings like "15" are parsed, clamped, and stored as numbers instead of falling back to the default interval.

Related Issue

Fixes #288

Changes Made

  • Updated sanitizeThemeAutomation() to accept numeric strings for checkIntervalMinutes.
  • Preserved existing clamping behavior for the valid 1..120 range.
  • Kept invalid values such as "abc", null, {}, and [] falling back to the default 30.
  • Added focused test coverage for numeric string, numeric, clamped, and invalid interval values.

Testing

  • npm.cmd test
  • 15 tests passed

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

@Shreya-nipunge is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 869d4e56-c16b-46f0-965e-afa822adba3b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SamXop123 SamXop123 merged commit df3771f into SamXop123:main Jul 5, 2026
4 of 7 checks passed
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

🎉 Congratulations @Shreya-nipunge! 🎉

Your pull request has been successfully merged into Paraline! Thank you so much for your valuable contribution and effort. Every single improvement helps make Paraline a better desktop experience for everyone! 🙌

🚀 What's Next?

  • Keep the momentum going! Feel free to browse through our open Issues and grab another one that interests you!
  • Support the Project: If you enjoyed contributing to Paraline, please take a second to star our repository! It helps increase the project's visibility and supports our community. ⭐

💬 Stay Connected:
Have any questions, want feedback, or just want to discuss further contributions? Feel free to reach out directly to the maintainer on Discord: dot_notsam!

Thank you again, and keep up the amazing work! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse numeric strings for automation interval

2 participants