Skip to content

fix(#289): reset animation clock while hidden#327

Merged
SamXop123 merged 1 commit into
SamXop123:mainfrom
Shreya-nipunge:fix-289-reset-animation-clock
Jul 5, 2026
Merged

fix(#289): reset animation clock while hidden#327
SamXop123 merged 1 commit into
SamXop123:mainfrom
Shreya-nipunge:fix-289-reset-animation-clock

Conversation

@Shreya-nipunge

Copy link
Copy Markdown
Contributor

Description

This PR fixes an animation timing issue that occurred when the visualizer was hidden. Previously, lastFrameAt was not updated while the visualizer was hidden, causing the next visible frame to use the entire hidden duration as deltaMs. This could make animated themes jump forward abruptly when the visualizer was shown again.

The fix resets the animation clock while hidden so animations resume smoothly without accumulating stale time.

Related Issue

Fixes #289

Changes Made

  • Updated the hidden-state path in renderFrame().
  • Reset lastFrameAt when visualizerState.hidden is true.
  • Prevented hidden duration from being included in the next frame's animation delta.
  • Kept the change minimal and limited to renderer.js.

Screenshots (if UI change)

Before: N/A (animation timing issue)

After: N/A (animation timing issue)

Checklist

  • I have read CONTRIBUTING.md
  • I have tested my changes locally
  • No new console errors
  • Linked the issue with 'Fixes #'

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

@Shreya-nipunge is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0fbc70aa-21a9-4b28-bfa3-7b6813f7af04

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SamXop123 SamXop123 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@SamXop123 SamXop123 merged commit d19db98 into SamXop123:main Jul 5, 2026
5 of 7 checks passed
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

🎉 Congratulations @Shreya-nipunge! 🎉

Your pull request has been successfully merged into Paraline! Thank you so much for your valuable contribution and effort. Every single improvement helps make Paraline a better desktop experience for everyone! 🙌

🚀 What's Next?

  • Keep the momentum going! Feel free to browse through our open Issues and grab another one that interests you!
  • Support the Project: If you enjoyed contributing to Paraline, please take a second to star our repository! It helps increase the project's visibility and supports our community. ⭐

💬 Stay Connected:
Have any questions, want feedback, or just want to discuss further contributions? Feel free to reach out directly to the maintainer on Discord: dot_notsam!

Thank you again, and keep up the amazing work! 💻✨

@Shreya-nipunge Shreya-nipunge deleted the fix-289-reset-animation-clock branch July 6, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset animation clock after hiding

2 participants