fix(#289): reset animation clock while hidden#327
Conversation
|
@Shreya-nipunge is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🎉 Congratulations @Shreya-nipunge! 🎉 Your pull request has been successfully merged into Paraline! Thank you so much for your valuable contribution and effort. Every single improvement helps make Paraline a better desktop experience for everyone! 🙌 🚀 What's Next?
💬 Stay Connected: Thank you again, and keep up the amazing work! 💻✨ |
Description
This PR fixes an animation timing issue that occurred when the visualizer was hidden. Previously,
lastFrameAtwas not updated while the visualizer was hidden, causing the next visible frame to use the entire hidden duration asdeltaMs. This could make animated themes jump forward abruptly when the visualizer was shown again.The fix resets the animation clock while hidden so animations resume smoothly without accumulating stale time.
Related Issue
Fixes #289
Changes Made
renderFrame().lastFrameAtwhenvisualizerState.hiddenistrue.renderer.js.Screenshots (if UI change)
Before: N/A (animation timing issue)
After: N/A (animation timing issue)
Checklist