[circle-resizer] Introduce a new tool to models resizing #14727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new tool for Circle model resizing. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <[email protected]>
8 tasks
mbencer
commented
Apr 23, 2025
| namespace | ||
| { | ||
|
|
||
| void change_single_input_shape(luci::CircleInput *circle_input, const Shape &new_shape) |
Contributor
Author
There was a problem hiding this comment.
@jinevening One thing to confirm here. Should circle-resizer also modify shape_signature attribute? I think no because it's a something specific for TF but I would like to confirm.
Collaborator
There was a problem hiding this comment.
circle uses shape_signature as well. PTAL luci/import/src/Importer.cpp.
(Not 100% sure) But you may not have to do further modification, because shape signature may be automatically set by encodeShapeSignature in CircleTensorExporter.cpp.
This was referenced Apr 24, 2025
This was referenced Apr 28, 2025
This was referenced May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new tool for Circle model resizing.
ONE-DCO-1.0-Signed-off-by: Mateusz Bencer [email protected]
Issue: #14791