[DRAFT] Additional Slicers for the refactor branch#197
Draft
krzywon wants to merge 7 commits intorefactor_24from
Draft
[DRAFT] Additional Slicers for the refactor branch#197krzywon wants to merge 7 commits intorefactor_24from
krzywon wants to merge 7 commits intorefactor_24from
Conversation
…lar limits of 0.0 to 2*pi
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the original
AnnularSector(i.e. wedge) slicer class to allowQuantitytypes for its parameters and ensure the parameter units are the expected type. It also adds individualAnnularandSectorclasses that are children of the wedge class.Things to do:
main()methods currently used for testing