Repository navigation
Conversation
…ent install.sh duplicate config
jpee1420
marked this pull request as ready for review
September 5, 2026 06:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatically cleans up multishell symlink directories when a shell tab or session exits.
Motivation
Currently, every
fnm envinvocation generates an isolated multishell symlink directory in the user's runtime directory (e.g./run/user/1000/fnm_multishells/...orAppData/Local/fnm_multishells). These directories are never deleted and accumulate indefinitely until system reboot.Changes
Shelltrait: Addedcleanup_on_exit(&self, multishell_path: &Path) -> Option<String>.trap __fnm_cleanup EXITusing an array accumulator so repeated evaluations in the same session (e.g.source ~/.bashrc) clean up all session directories.add-zsh-hook zshexit _fnm_cleanup(idiomatic, doesn't overwrite existing traps).--on-event fish_exit.Register-EngineEvent -SourceIdentifier PowerShell.Exiting.install.sh: Added idempotency guard (grep -q "fnm env") to prevent duplicate blocks if the installer is run more than once.cargo test shell::).e2e/multishell-cleanup.test.ts).