Repository navigation
fix: use POSIX compliant [ ] syntax instead of bash-only [[ ]] in env --use-on-cd - #1595
Closed
RohithPariki wants to merge 1 commit into
Closed
RohithPariki wants to merge 1 commit into
RohithPariki wants to merge 1 commit into
Conversation
… --use-on-cd (fixes Schniz#1591)
Author
|
Closing PR: This was an automated experimental submission while testing a new contribution workflow, and upon review, the implementation is too trivial to justify maintainer review time. Apologies for the noise! |
Author
|
Closing PR: Re-evaluated and this is too trivial of a change. Closing permanently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1591 by using the POSIX compliant [ ]\ syntax instead of the bash-only [[ ]]\ in the script generated by \ nm env --use-on-cd\ for bash and zsh. This ensures compatibility for users whose /bin/sh\ is \dash\ and who eval the output of \ nm env\ in global profile scripts.