Repository navigation
usbtreeview: Add version 4.8.0 - #15600
Conversation
|
All changes look good. Wait for review from human collaborators. usbtreeview
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. usbtreeview
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. usbtreeview
|
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Manifest downloads and package configuration bucket/usbtreeview.json |
Adds architecture-specific download URLs and SHA-256 hashes. Configures INI file initialization and persistence, the executable and Start Menu shortcut, version detection, and autoupdate URLs. |
Priority:
Merge Risk: 
ebd2a
-
No merge-blocking issue is established in the manifest.
Pre-merge checks: 
-
Check name Status Explanation Resolution Description check The description only contains Closes #15599. It does not provide a change summary or confirm the required repository checks from the template.Add a brief summary of the manifest changes and complete the required checklist items, including confirmation that the Contributing Guide was read. -
Check name Status Explanation Linked Issues check [ #15599] The request asks for a Scoop package for UsbTreeView. The whole-PR diff against the merge base adds one file, bucket/usbtreeview.json (+43 lines). The manifest meets the concrete coding requi…Out of Scope Changes check The whole-PR diff against the merge base changes one file: bucket/usbtreeview.json, a new Scoop manifest. Every field in it serves the package request in #15599. No unrelated files, refactors, or docu…Title check The title clearly identifies the package and the main change: adding USBTreeView version 4.8.0. Full details: Linked Issues check
-
Explanation
[
#15599] The request asks for a Scoop package for UsbTreeView. The whole-PR diff against the merge base adds one file, bucket/usbtreeview.json (+43 lines). The manifest meets the concrete coding requirements from the issue:- Homepage is https://www.uwe-sieber.de/usbtreeview_e.html, as the issue requests.
- Description is "USB Device Tree Viewer".
- Download URLs cover 64-bit, 32-bit, and ARM64. They match the three packages listed in the issue (x64, Win32, arm64 zips). The files use versioned names (UsbTreeView480_*.zip), which satisfies the criterion for a version-specific download URL.
- Each architecture has a SHA-256 hash field.
- The install step is limited to one pre_install line that creates UsbTreeView.ini if it is missing. It is not an elaborate script, and the persist entry keeps the INI file.
- bin and shortcuts expose UsbTreeView.exe.
- checkver and autoupdate are defined for all three architectures.
The manifest declares version 4.8.0. This matches the commit message. The PR title says 4.7.2, which is a metadata mismatch and not a manifest defect. The repository does not establish that 4.8.0 is the latest upstream release, and the hash values cannot be checked without network access. These points are outside the repository evidence. No test or other coding requirement is stated in the issue.
Full details: Out of Scope Changes check
-
Explanation
The whole-PR diff against the merge base changes one file: bucket/usbtreeview.json, a new Scoop manifest. Every field in it serves the package request in
#15599. No unrelated files, refactors, or documentation changes are present. The PR title (version 4.7.2) differs from the manifest and commit message (4.8.0). This is a labeling issue, not an out-of-scope change.
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
/verify |
|
All changes look good. Wait for review from human collaborators. usbtreeview
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
bucket/usbtreeview.json (1)
11-14: Confirm 32-bit flavor choice (Win32 vs Win32_VC6).Upstream offers both Win32 and Win32_VC6; VC6 has fewer AV hits but lacks some data/help. If compatibility is the goal, VC6 is fine; otherwise consider standard Win32. (uwe-sieber.de)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
bucket/usbtreeview.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/usbtreeview.json (2)
24-30: LGTM: bin/shortcut entries are sane.Executable and Start Menu path look correct.
32-32: checkver regex won’t match current page; use the “Vx.y.z (” pattern.The page lists versions as “V4.5.2 (YYYY-MM-DD)”. Your current regex requires the literal “USB Device Tree Viewer V…”, which doesn’t appear. Update to match Latest History entries. (uwe-sieber.de)
Apply:
- "checkver": "USB Device Tree Viewer V([\\d.]+)", + "checkver": { + "url": "https://www.uwe-sieber.de/usbtreeview_e.html", + "regex": "V([\\d.]+)\\s*\\(" + },Likely an incorrect or invalid review comment.
|
Anything I can do to help @BoringBoredom get this PR accepted? |
aliesbelik
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. usbtreeview
|
Gitoffthelawn
left a comment
Gitoffthelawn
left a comment
There was a problem hiding this comment.
@aliesbelik Thank you for working on this. Out of interest of learning so I can help more in the future, why did you choose to use versioned download artifacts instead of the non-versioned ones?
|
/verify |
|
All changes look good. Wait for review from human collaborators. usbtreeview
|
aliesbelik
changed the title
Closes #15599