Skip to content

brimdeck: Add version 1.2.1 - #19165

Open
Weidows wants to merge 1 commit into
ScoopInstaller:masterfrom
Weidows:brimdeck
Open

Weidows wants to merge 1 commit into
ScoopInstaller:masterfrom
Weidows:brimdeck

Conversation

@Weidows

@Weidows Weidows commented Oct 26, 2026

Copy link
Copy Markdown

Closes #19164

Adds brimdeck, a Dynamic Island for Windows 11 (x64). Apache-2.0, English and Simplified Chinese UI.

  • Single Inno Setup (7.1.0) installer with a version-specific URL, so "innosetup": true is enough - verified it extracts with innounp 2.70.1 (486 files, BrimDeck.exe 1.2.1.0), no installer/uninstaller scripts.
  • checkver: github: upstream also publishes alpha/beta prereleases, but /releases/latest skips them, so only stable versions are tracked.
  • Settings, themes and API keys live in %LOCALAPPDATA%\BrimDeck, so there is nothing to persist; that and "quit from the tray before uninstalling" are in notes.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 13428c4 and 46a72a2.

Files selected for processing: 1
  • bucket/brimdeck.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

Adds a Scoop manifest for BrimDeck version 1.2.1. The manifest specifies the 64-bit Inno Setup installer and its SHA-256 hash, defines a shortcut, and configures GitHub version checking and URL-based autoupdates. It also notes that user data remains under %LOCALAPPDATA%\BrimDeck after uninstall and instructs users to quit BrimDeck from the tray before uninstalling.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: Minimal · up to 46a72

The BrimDeck manifest is supported and has no established merge-blocking issue.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "brimdeck: Add version 1.2.1" follows the required convention of manifest name plus version. It names the app and the change (a new version manifest), which matches the changeset that adds b…
Description check Passed The description covers the template's key points. It links issue #19164 with a closing keyword, and it explains the installer type, the checkver approach, and the persistence and uninstall notes. The …
Linked Issues check Passed Issue #19164 requires a BrimDeck package for the latest stable full version, with English support and a standard install. bucket/brimdeck.json packages version 1.2.1 for 64-bit Windows, uses the v…
Out of Scope Changes check Passed The pull request changes only bucket/brimdeck.json. The manifest metadata, installer declaration, shortcut, version check, autoupdate URL, and uninstall notes directly support the BrimDeck packaging…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Title check

Explanation

The title "brimdeck: Add version 1.2.1" follows the required convention of manifest name plus version. It names the app and the change (a new version manifest), which matches the changeset that adds bucket/brimdeck.json for BrimDeck 1.2.1. It is short, specific, and contains no file lists or vague terms.

Full details: Description check

Explanation

The description covers the template's key points. It links issue #19164 with a closing keyword, and it explains the installer type, the checkver approach, and the persistence and uninstall notes. The template's checklist items (conventional title and Contributing Guide confirmation) are not visibly ticked in the author's text. The author also does not state that they searched for similar PRs, which the template asks for.

Resolution

Optionally tick the template checkboxes: confirm the conventional title format and that the Contributing Guide was read. The description is otherwise complete.

Full details: Linked Issues check

Explanation

Issue #19164 requires a BrimDeck package for the latest stable full version, with English support and a standard install. bucket/brimdeck.json packages version 1.2.1 for 64-bit Windows, uses the version-specific Inno Setup URL, includes a SHA-256 hash, sets innosetup: true, and defines a shortcut. checkver: github and the versioned autoupdate URL support stable release tracking. The linked issue and PR description provide the English UI and full-version evidence. No elaborate install or uninstall scripts are present.

Full details: Out of Scope Changes check

Explanation

The pull request changes only bucket/brimdeck.json. The manifest metadata, installer declaration, shortcut, version check, autoupdate URL, and uninstall notes directly support the BrimDeck packaging objective in issue #19164. No unrelated product or repository changes are present.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Weidows

Weidows commented Oct 26, 2026

Copy link
Copy Markdown
Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

brimdeck

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@aliesbelik

Copy link
Copy Markdown
Collaborator

Guess could be postponed until portable version will be added (MoFeng2223/BrimDeck#97).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: BrimDeck

2 participants