Skip to content

ghidra@12.2-20261016: Update to JDK 25 - #19169

Merged
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
InfiniteLoopGameDev:patch-1
Oct 29, 2026
Merged

z-Fng merged 1 commit into
ScoopInstaller:masterfrom
InfiniteLoopGameDev:patch-1

Conversation

@InfiniteLoopGameDev

Copy link
Copy Markdown
Contributor

As stated by the minimum required software in the latest release of Ghidra it now requires at least JDK 25

  • [ x] Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • [ x] I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 04d098c and 8a75ece.

Files selected for processing: 1
  • bucket/ghidra.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The Ghidra manifest now requires JDK 25 on PATH and recommends java/temurin25-jdk. The extraction directory is unchanged.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: Minimal · up to 8a75e

No actionable merge-blocking issue remains in the JDK requirement update.

Pre-merge checks: Passed 4
Check name Status Explanation
Description check Passed The description gives the reason for the JDK 25 update and confirms both required checklist items. It does not include an issue reference, but the description is otherwise complete.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title "ghidra@12.2-20261016: Update to JDK 25" matches the changeset. The manifest bucket/ghidra.json now requires JDK 25 on PATH and recommends java/temurin25-jdk instead of JDK 21 and java/temur…
Full details: Title check

Explanation

The title "ghidra@12.2-20261016: Update to JDK 25" matches the changeset. The manifest bucket/ghidra.json now requires JDK 25 on PATH and recommends java/temurin25-jdk instead of JDK 21 and java/temurin21-jdk. The PR objectives say the latest Ghidra release requires at least JDK 25. The title names the package version and the main change, so it is fully related.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@z-Fng z-Fng changed the title ghidra: Update to JDK 25 ghidra@12.2-20261016: Update to JDK 25 Oct 29, 2026
@z-Fng
z-Fng merged commit ea2c252 into ScoopInstaller:master Oct 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants