feat(dashboard): add section header tiles with analytics - #26
Open
justinsunyt wants to merge 2 commits into
Open
feat(dashboard): add section header tiles with analytics#26justinsunyt wants to merge 2 commits into
justinsunyt wants to merge 2 commits into
Conversation
… layout and analytics Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dashboard users need a first-class way to group tiles into sections without learning the generic text tile markdown and transparency settings.
Changes
smandxs, including layout fallback behavior for section-like text tiles without stored layouts.How did you test this code?
Agent-tested with:
hogli test frontend/src/lib/components/Cards/TextCard/textCardModalLogic.test.ts frontend/src/lib/components/Cards/TextCard/TextCard.test.tsx frontend/src/scenes/dashboard/EmptyDashboardComponent.test.tsx frontend/src/scenes/dashboard/tileLayouts.test.tspnpm --filter=@posthog/frontend formatpnpm --filter=@posthog/frontend typescript:checkpnpm --filter=@posthog/frontend build:products# Activationwith transparent background and full-widthsm/xslayouts, dragged the section in edit mode, and observed bothdashboard section header addedanddashboard section header rearrangedcaptures.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Automatic notifications
Docs update
No docs update needed.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented by Capy. I kept sections on the existing text-tile model rather than adding a new tile type, so persistence, editing, duplication, and dashboard layout flows continue to use the existing dashboard tile system.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.