Conversation
Create a simple LICENSE file
Fix README typo for guarenetted=> guaranteed
I found the section in Sefaria-Project clearer, especially the clarification that the download is a .gz and it just needs to be unzipped first (for it to be recognized as a BSON file).
Update README.md
Automated code reviewThis is an automated review (Claude), run by a Sefaria maintainer as part of a sweep through our long-open pull requests. A human is reading the results. @bor1e — thank you for this, and I'm sorry it sat for three years without a reply. That's on us, not you. Your three catches were all correct:
We verified them against our current live data, and all three are now fixed. The Hirsch German Pentateuch today reads "Sohn Nuns" (9×), "höhnen!" and "und seine Huldigungsgabe". Your PR was never merged, so a later re-export corrected them independently — but your diagnosis was right on every count. Why we can't merge the patch itself: in March 2026 this repository stopped holding text data. The One thing your review surfaced that we're passing on: the same Hirsch edition still carries three stray Hebrew characters left over from scanning — We'd like to hear what you want to do. We're not closing this unilaterally after leaving it this long. If you'd like to talk it through, or keep contributing text corrections through the right channel, please join our developer Discord: 👉 https://sefaria.formstack.com/forms/sefaria_developer_discord_community Thank you for the careful eye, and again — sorry for the silence. |
Follow-up: this PR was closed automatically, not by a decisionShortly after the review above, we reset this repository's git history — moving ~14 GB of accumulated history into a read-only archive so a clone drops from ~14 GB to under 1 MB. That force-push auto-closed this PR. We did not expect it to: we believed GitHub only auto-closes a pull request when its base branch is deleted, and we rewrote I'm flagging it because the comment above said we wanted to hear from you "rather than close this on you after so long" — and then a migration closed it minutes later. That's a bad look and it wasn't the intent. We got the mechanics wrong; we didn't change our minds. Nothing of yours is lost. Your fork is untouched and your commits are intact, and the complete pre-reset history is preserved at Sefaria-Export-Archive. If you'd like this reopened to continue the conversation, say so and we'll reopen it — the diff view will be unusable (no common ancestor with the new root commit), but the thread still works. 👉 https://sefaria.formstack.com/forms/sefaria_developer_discord_community |
|
Hi — a note on where this stands. We had to make some changes to this repository (moving ~14 GB of git history into a read-only archive), and that's what closed your PR. Reopening isn't possible — GitHub blocks it because the merge base no longer exists. We're not asking you to re-submit this one, and that's not a judgement on the work: as noted in the review above, the issue you reported is already resolved in our current published data, so a new PR would have nothing left to fix. You were right; it just got fixed by another route while this sat unanswered. Please do join our developers Discord, though — we'd rather hear about the next thing you spot somewhere it will actually get seen: 👉 https://sefaria.formstack.com/forms/sefaria_developer_discord_community Thank you for the contribution, and sorry for how long it went without a reply. |
12 participants
Fixed some scan typos.
Jehoshua ben "Nun" not "Run"
added exclamation mark "höhnenl" -> "höhnen!"
seperated words "undseine" -> "und seine"