Skip to content

Remove contact information temporarily - #3650

Merged
relyks merged 1 commit into
masterfrom
temporarily-remove-contact-info-supporters-page
Sep 3, 2026
Merged

Remove contact information temporarily#3650
relyks merged 1 commit into
masterfrom
temporarily-remove-contact-info-supporters-page

Conversation

@relyks

@relyks relyks commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

The mentioned person is no longer with Sefaria. Dev requested that the section be temporarily removed.

@relyks
relyks requested a review from yitzhakc August 21, 2026 19:32
@relyks relyks self-assigned this Aug 21, 2026
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 2/100

9 × 0.25 (Micro ESF) = 2.25, rounded to 2

Category Score Factors
🔭 Scope 2/20 One file modified: templates/static/supporters.html. A single section block (h2 + p) is commented out. No other files or subsystems are touched.
🏗️ Architecture 0/20 No module boundary changed. This is a content-only modification to a static HTML template with no structural or dependency impact.
⚙️ Implementation 1/20 The change wraps 16 lines of HTML in per-line HTML comments. No logic, branching, or data handling is involved.
⚠️ Risk 2/20 The change removes a publicly rendered contact section (name, email) from a live page. Reversal requires uncommenting the block. No migration, auth path, or API contract is affected.
✅ Quality 3/15 No tests are applicable for a static HTML template change. No PR description or inline comment explains why the contact section is being hidden or whether the removal is temporary or permanent.
🔒 Perf / Security 1/5 Commenting out the section removes a publicly exposed email address (samantha@sefaria.org) from rendered HTML, reducing email harvesting surface. No performance work is present.

Was this score accurate? 👍 Yes · 👎 No

How this was scored →

Scored by GitVelocity · How are scores calculated?

@yitzhakc
yitzhakc added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 2, 2026
@relyks
relyks added this pull request to the merge queue Sep 3, 2026
Merged via the queue into master with commit f582ca1 Sep 3, 2026
18 checks passed
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 1/100

5 × 0.25 = 1.25, rounded to 1

Category Score Factors
🔭 Scope 2/20 One file modified: templates/static/supporters.html. A single section of a static supporters page is hidden; no other subsystems or files are touched.
🏗️ Architecture 0/20 No module boundary changed.
⚙️ Implementation 1/20 The change wraps 16 lines of existing HTML in HTML comment delimiters. No control flow, no logic, no data transformation.
⚠️ Risk 2/20 Removes a public-facing contact email and heading from the supporters page. Reversal requires only uncommenting the same lines.
✅ Quality 0/15 No test accompanies the change; none is warranted for a static template comment-out.
🔒 Perf / Security 0/5 No performance or security work present.

Was this score accurate? 👍 Yes · 👎 No

How this was scored →

Scored by GitVelocity · How are scores calculated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants