[Klaud Cold] Signoff verifier: Check 3 recipe link is N/A for disagg/multi-node PRs#2030
Conversation
Upstream recipe sources (vLLM recipes, SGLang cookbook) publish single-node serve commands, so the recipe-link requirement only applies to single-node recipes. Disagg/multi-node PRs (dynamo, ATOM/ATOMesh, sglang/vllm disagg, srt-slurm-recipes) now report N/A instead of FAIL, fixing false rejections like PR #1963. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
LGTM — prompt-only tweak to scope Check 3 to single-node recipes; no workflow logic or permission changes.
Extended reasoning...
Overview
This PR modifies only the Claude prompt text inside .github/workflows/codeowner-signoff-verify.yml. Specifically, it updates the description of Check 3 (recipe linked + complete) to explicitly scope the requirement to single-node recipes and report disaggregated / multi-node submissions as N/A rather than FAIL. It also updates the header comment block accordingly.
Security risks
None. The change touches only natural-language instructions given to Claude within the workflow; it does not alter permissions, secrets handling, the trusted-branch checkout policy, the MCP config, the concurrency group, or any of the surrounding shell/JavaScript logic. The security-critical property of this workflow — that it never checks out untrusted PR head code — is preserved.
Level of scrutiny
Low. This is a prompt-clarification change to a workflow that gates merges, but the modification narrows a false-positive failure mode (disagg/multi-node PRs getting FAIL on Check 3 despite having no upstream recipe source) and does not weaken any of the eight substantive gates. The listed disagg indicators (multinode: true, disagg: true, dynamo-trt/dynamo-sglang, ATOM/ATOMesh, sglang-disagg, benchmarks/multi_node/**, srt-slurm-recipes/**) match established framework/config conventions in the repo.
Other factors
Bug hunting system found no bugs. Mixed PRs still get single-node recipe enforcement per the added explicit instruction. The change is small, self-contained, and cleanly reversible.
Summary
benchmarks/multi_node/**incl.srt-slurm-recipes/**, master-config entries withmultinode: true/disagg: true) now report➖ N/Ainstead of❌ FAIL.Test plan
🤖 Generated with Claude Code