Develop - #695
Merged
Merged
Conversation
…ox (Changed isTouchDevice detection to check actual input device)
Fix wrong touch device detection causing all videos card to automatically start under certain conditions
Auth Whitelist / MFA
OpenLDAP had no CA configured (the images ship ca-certificates but not libldap-common's ldap.conf), so every LDAPS handshake failed with a bare SERVER_DOWN. Connections now verify against the system CA bundle, with LDAP_TLS_CACERT and LDAP_TLS_REQCERT for private CAs, and TLS failures log what to actually check. Also fixes LDAP_ENABLE=false, LDAP_STARTLS and DISABLE_ADMINCREATE being treated as true for any value, implements the previously unused LDAP_STARTLS, adds connect/operation timeouts, reconnects stale binds instead of failing until restart, keeps serving when the LDAP server is unreachable at startup, and unbinds the connection on a failed login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two-factor authentication (TOTP) and login IP whitelisting to Fireshare, improves the video modal's responsive layout for short and narrow viewports, and enhances the login form to support the new multi-step authentication flow. It also includes minor UI improvements and updates the application version.
Security & Authentication Enhancements
README.mdandSecurity.md. The login form now supports a multi-step flow for MFA, including code entry and error handling. (README.md,app/client/src/components/forms/LoginForm.js) [1] [2] [3] [4] [5] [6]loginAllowedprop, hiding the login button when login is disabled. (app/client/src/components/nav/MainNavbar.js) [1] [2]UI/UX Improvements
app/client/src/components/cards/CompactImageCard.js,app/client/src/components/cards/CompactVideoCard.js,app/client/src/components/cards/MasonryImageCard.js) [1] [2] [3]app/client/src/components/cards/CompactVideoCard.js)Responsive Layout Improvements
app/client/src/components/modal/VideoModal.js) [1] [2] [3] [4] [5] [6] [7]Maintenance
1.7.7inpackage.json.