You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Observe PreloadState in the Swift and Android sample apps using the existing public preload callbacks.
Expose the current state as matching, invisible test IDs such as preload-state-ready.
Add unit tests for the cross-platform state-to-ID mappings.
Why
Maestro cannot read an in-memory Swift/Kotlin preload state. These markers let native E2E tests wait until a real checkout finishes preloading before presentation.
The markers add no visible UI and no public SDK API. The first flow only needs preload-state-ready; the other states are useful for debugging and potential future failure coverage.
PreloadState.Failed now carries a diagnostic message on both platforms. The mappings key only on the stable reason and ignore that message.
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.
I might wait for RN because it can't use this approach yet. This PR maps the native PreloadState callbacks to identifiers, and until #654there was no equivalent on RN. #656 is already adding RN sample preload observability, so building on that makes sense imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PreloadStatein the Swift and Android sample apps using the existing public preload callbacks.preload-state-ready.Why
Maestro cannot read an in-memory Swift/Kotlin preload state. These markers let native E2E tests wait until a real checkout finishes preloading before presentation.
The markers add no visible UI and no public SDK API. The first flow only needs
preload-state-ready; the other states are useful for debugging and potential future failure coverage.PreloadState.Failednow carries a diagnostic message on both platforms. The mappings key only on the stable reason and ignore that message.Testing
dev swift test sampledev android test demodev swift lintdev android check detektStack
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.