Decorate checkout URLs in CheckoutViewController - #649
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
Decorate checkout URLs in CheckoutViewController#649kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
Assisted-By: devx/e431cd55-e9d8-49d7-9154-66877c8dda59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
CheckoutViewControlleris public. It is missing the ecp query params so it never subscribes to protocol.All API's route through
CheckoutViewController, and decorate the url before instantiating itThis PR moves the decoration logic into
CheckoutViewController, so all paths are covered equally.Fixes shop/issues-checkout-kit#1215.
What changes are you making?
This change:
CheckoutViewControllerinitializersHow to test
dev swift testdev swift lintdev swift api checkBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)README changes are not required because the documented presentation APIs and usage remain unchanged.
Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.