-
Notifications
You must be signed in to change notification settings - Fork 14
Add TurboModule specs and codegen components to prepare RN new-arch migration #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kieran-osgood-shopify
wants to merge
12
commits into
main
Choose a base branch
from
cx-rn-new-arch-plan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
909b882
chore: bump dev.yml to iOS 26.2
kieran-osgood-shopify d66e1d5
Add TurboModule specs and codegen components to prepare RN new-arch m…
kieran-osgood-shopify f52c3f7
Remove cart from orderDetails type and simplify sample RN scripts
kieran-osgood-shopify b6cd3e1
Add native spec files to support React Native new-arch migration
kieran-osgood-shopify 3464869
Make npm upgrade non-fatal in CI setup for broken macOS runners
kieran-osgood-shopify 0ce385f
Add plugin repositories to Android settings.gradle for resilient depe…
kieran-osgood-shopify 99f0480
Update action.yml
kieran-osgood-shopify c8b838f
Update action.yml
kieran-osgood-shopify 17436a9
Make npm upgrade non-fatal in CI setup for broken macOS runners
kieran-osgood-shopify 60a509b
revert npm upgrade
kieran-osgood-shopify 75de418
test: migrate tests to use TurboModuleRegistry
kieran-osgood-shopify c99a638
fix(lint): use top-level codegenNativeComponent import
kieran-osgood-shopify File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
modules/@shopify/checkout-sheet-kit/src/specs/NativeShopifyCheckoutSheetKit.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /* | ||
| MIT License | ||
|
|
||
| Copyright 2023 - Present, Shopify Inc. | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| */ | ||
|
|
||
| import type {TurboModule} from 'react-native'; | ||
| import {TurboModuleRegistry} from 'react-native'; | ||
|
|
||
| type IosColorsSpec = { | ||
| tintColor?: string; | ||
| backgroundColor?: string; | ||
| closeButtonColor?: string; | ||
| }; | ||
|
|
||
| type AndroidColorsBaseSpec = { | ||
| progressIndicator?: string; | ||
| backgroundColor?: string; | ||
| headerBackgroundColor?: string; | ||
| headerTextColor?: string; | ||
| closeButtonColor?: string; | ||
| }; | ||
|
|
||
| type AndroidColorsSpec = { | ||
| progressIndicator?: string; | ||
| backgroundColor?: string; | ||
| headerBackgroundColor?: string; | ||
| headerTextColor?: string; | ||
| closeButtonColor?: string; | ||
| light?: AndroidColorsBaseSpec; | ||
| dark?: AndroidColorsBaseSpec; | ||
| }; | ||
|
|
||
| type ColorsSpec = { | ||
| ios?: IosColorsSpec; | ||
| android?: AndroidColorsSpec; | ||
| }; | ||
|
|
||
| type ConfigurationSpec = { | ||
| preloading?: boolean; | ||
| title?: string; | ||
| colorScheme?: string; | ||
| logLevel?: string; | ||
| colors?: ColorsSpec; | ||
| }; | ||
|
|
||
| type ConfigurationResultSpec = { | ||
| preloading: boolean; | ||
| colorScheme: string; | ||
| logLevel: string; | ||
| title?: string; | ||
| tintColor?: string; | ||
| backgroundColor?: string; | ||
| closeButtonColor?: string; | ||
| }; | ||
|
|
||
| export interface Spec extends TurboModule { | ||
| present(checkoutUrl: string): void; | ||
| preload(checkoutUrl: string): void; | ||
| dismiss(): void; | ||
| invalidateCache(): void; | ||
| setConfig(configuration: ConfigurationSpec): void; | ||
| getConfig(): Promise<ConfigurationResultSpec>; | ||
| configureAcceleratedCheckouts( | ||
| storefrontDomain: string, | ||
| storefrontAccessToken: string, | ||
| customerEmail: string | null, | ||
| customerPhoneNumber: string | null, | ||
| customerAccessToken: string | null, | ||
| applePayMerchantIdentifier: string | null, | ||
| applyPayContactFields: string[], | ||
| supportedShippingCountries: string[], | ||
| ): Promise<boolean>; | ||
| isAcceleratedCheckoutAvailable(): Promise<boolean>; | ||
| isApplePayAvailable(): Promise<boolean>; | ||
| initiateGeolocationRequest(allow: boolean): void; | ||
| addListener(eventName: string): void; | ||
| removeListeners(count: number): void; | ||
| getConstants(): {version: string}; | ||
| } | ||
|
|
||
| export default TurboModuleRegistry.getEnforcing<Spec>( | ||
| 'ShopifyCheckoutSheetKit', | ||
| ); |
81 changes: 81 additions & 0 deletions
81
...les/@shopify/checkout-sheet-kit/src/specs/RCTAcceleratedCheckoutButtonsNativeComponent.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| /* | ||
| MIT License | ||
|
|
||
| Copyright 2023 - Present, Shopify Inc. | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| */ | ||
|
|
||
| import {codegenNativeComponent, type ViewProps} from 'react-native'; | ||
| import type { | ||
| BubblingEventHandler, | ||
| DirectEventHandler, | ||
| Double, | ||
| Float, | ||
| // eslint-disable-next-line @react-native/no-deep-imports -- codegen parser requires these type names to be imported directly (not via aliases) so it can match them statically during AST traversal | ||
| } from 'react-native/Libraries/Types/CodegenTypes'; | ||
|
|
||
| type FailEvent = Readonly<{ | ||
| __typename: string; | ||
| message: string; | ||
| code?: string; | ||
| recoverable?: boolean; | ||
| }>; | ||
|
|
||
| type CompleteEvent = Readonly<{ | ||
| orderDetails: Readonly<{ | ||
| id: string; | ||
| email?: string; | ||
| phone?: string; | ||
| }>; | ||
| }>; | ||
|
|
||
| type RenderStateChangeEvent = Readonly<{ | ||
| state: string; | ||
| reason?: string; | ||
| }>; | ||
|
|
||
| type ClickLinkEvent = Readonly<{url: string}>; | ||
| type SizeChangeEvent = Readonly<{height: Double}>; | ||
|
|
||
| type CheckoutIdentifierSpec = Readonly<{ | ||
| cartId?: string; | ||
| variantId?: string; | ||
| quantity?: Double; | ||
| }>; | ||
|
|
||
| interface NativeProps extends ViewProps { | ||
| checkoutIdentifier: CheckoutIdentifierSpec; | ||
| cornerRadius?: Float; | ||
| wallets?: ReadonlyArray<string>; | ||
| applePayLabel?: string; | ||
| onFail?: BubblingEventHandler<FailEvent>; | ||
| onComplete?: BubblingEventHandler<CompleteEvent>; | ||
| onCancel?: BubblingEventHandler<null>; | ||
| onRenderStateChange?: BubblingEventHandler<RenderStateChangeEvent>; | ||
| onWebPixelEvent?: BubblingEventHandler<Readonly<{data: string}>>; | ||
| onClickLink?: BubblingEventHandler<ClickLinkEvent>; | ||
| onSizeChange?: DirectEventHandler<SizeChangeEvent>; | ||
| onShouldRecoverFromError?: DirectEventHandler< | ||
| Readonly<{recoverable: boolean}> | ||
| >; | ||
| } | ||
|
|
||
| export default codegenNativeComponent<NativeProps>( | ||
| 'RCTAcceleratedCheckoutButtons', | ||
| ); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this type assertion is removed up stack with a parser to coerce the values to ts enums