Add DOM.Iterable to hydrogen-react tsconfig lib#3766
Open
LeSingh1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
packages/hydrogen-react/tsconfig.jsonlibsetting was["DOM", "ESNext"], which is missingDOM.Iterable. Without it, the type definitions forURLSearchParams,FormData,Headers,NodeList, and similar DOM iterables do not expose their[Symbol.iterator]method, so iterating them (or spreading them intoObject.fromEntries) does not type-check.This forced a workaround in
useSelectedOptionInUrlParam.tsx: two@ts-ignoredirectives plus matchingeslint-disablecomments, alongside an outdatedTODO: update ts lib. The roottsconfig.jsonat the monorepo root already setslib: ["DOM", "DOM.Iterable", "ESNext"], so this brings the package into line with the rest of the workspace.WHAT is this pull request doing?
DOM.Iterableto thelibarray inpackages/hydrogen-react/tsconfig.json.@ts-ignore/eslint-disableworkaround and the staleTODOcomment inuseSelectedOptionInUrlParam.tsx. The runtime behaviour is unchanged.HOW to test your changes?
From the repo root after
pnpm install:tsc --noEmitpasses with the workaround removed.Checklist