[#16670] dist-trace: add TraceContextPB and RequestHeader.trace_context - #12
Open
ellabaron-code wants to merge 1 commit into
Open
[#16670] dist-trace: add TraceContextPB and RequestHeader.trace_context#12ellabaron-code wants to merge 1 commit into
ellabaron-code wants to merge 1 commit into
Conversation
Author
|
Misfiled: reopening against yugabyte/yugabyte-db. |
ellabaron-code
changed the title
ellabaron-code
force-pushed
the
dist-trace-01-proto
branch
from
July 13, 2026 14:55
8c92dd5 to
d8482be
Compare
Define TraceContextPB (W3C trace-context) and the trace_context field on the RPC RequestHeader, both in rpc_header.proto. This is the wire type shared by the RPC-header and shared-memory trace-propagation transports; no code references it yet.
ellabaron-code
force-pushed
the
dist-trace-01-proto
branch
from
July 13, 2026 16:11
d8482be to
b0a2761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define TraceContextPB (W3C trace-context) in common.proto and add the
trace_context field to the RPC RequestHeader. This is the wire type shared by
the RPC-header and shared-memory trace-propagation transports; no code
references it yet.
Upgrade/Downgrade Safety: Additive protobuf-only change. It adds a new message
(TraceContextPB) and a new optional field (RequestHeader.trace_context, field
8); no code reads the field yet, so runtime behavior is unchanged. Older
binaries ignore the unknown field, so mixed-version clusters and rollback are
safe. No special upgrade or downgrade procedure is required.