Repository navigation
Fix statistics timestamps for partially timed paths - #88
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Fixes #51 on the stable
masterbranch. Route and segment statistics now use the first and last non-null timestamps in point order. Track statistics take those timestamps from their segments, including when entire boundary segments are untimed.Endpoint coordinates still describe the complete path. Duration, speed and pace keep their existing requirement for timestamps on the original endpoints: a partial time range cannot measure the duration of the whole path.
Added 22 PHPUnit cases covering missing boundary/interior timestamps, a single timestamp, entirely untimed paths, recorded order, recalculation and a multi-segment GPX XML round trip. Sixteen cases fail before the fix; all 22 pass afterward on PHP 7.3, 8.0 and 8.1 in Docker.
The full suite runs 70 tests with one existing failure on each of those PHP versions:
SegmentParserTest::testToJSONcompares floating-point JSON values exactly (for example,2.9798324749548644versus2.979832475456357). Unchanged upstream has the same failure among its 48 tests. PHP CS Fixer passes for all four changed files with the project's.php-cs-fixer.phpconfiguration, andcomposer archivesucceeds.