Skip to content

Fix for user-defined inlet velocity profile failure #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktbolt wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −2
Open

Fix for user-defined inlet velocity profile failure #556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533af1a
Add check if lBc.gx is already allocated.
ktbolt May 27, 2026
75715f1
Merge branch 'main' into User-defied-inlet-velocity-profile-fails_555
ktbolt May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Code/Source/solver/baf_ini.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,13 @@ void bc_ini(const ComMod& com_mod, const CmMod& cm_mod, bcType& lBc, faceType& l

int iM = lFa.iM;
int iFa = lBc.iFa;
lBc.gx.resize(lFa.nNo);
//if (.NOT.ALLOCATED(lBc.gx)) ALLOCATE(lBc.gx(lFa.nNo))

// lBc.gx may have values set when for example when
Copy link
Copy Markdown
Collaborator

@aabrown100-git aabrown100-git May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktbolt do you have a test you can add for user-defined spatial profile?

// reading in a user-defined profile.
if (lBc.gx.size() == 0) {
Copy link
Copy Markdown
Collaborator

@aabrown100-git aabrown100-git May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, so previously any time a user defined a spatial profile the solver would fail?

Copy link
Copy Markdown
Collaborator Author

@ktbolt ktbolt May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aabrown100-git Correct; there are no CI tests for the Spatial_profile_file_path parameter.

lBc.gx.resize(lFa.nNo);
}
Comment on lines +301 to +305
Copy link
Copy Markdown
Collaborator

@aabrown100-git aabrown100-git May 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktbolt is it worth validating that lBc.gx.size() == lFa.nNo if it's not 0?


#ifdef debug_bc_ini
dmsg << "iM: " << iM;
dmsg << "iFa: " << iFa ;
Expand Down
Loading