[bpk-component-modal] Migrate customPropTypes to TypeScript#4763
Open
Gert-Jan Vercauteren (gert-janvercauteren) wants to merge 4 commits into
Open
[bpk-component-modal] Migrate customPropTypes to TypeScript#4763Gert-Jan Vercauteren (gert-janvercauteren) wants to merge 4 commits into
Gert-Jan Vercauteren (gert-janvercauteren) wants to merge 4 commits into
Conversation
Migrates bpk-component-modal from JavaScript to TypeScript as described in #4750. - Replaced prop-types with TypeScript interfaces - Converted defaultProps to ES6 destructure defaults - Renamed .js source/test/story files to .tsx/.ts - Removed Flow type annotations - Preserved Apache 2.0 license headers Closes #4750
Contributor
|
Visit https://backpack.github.io/storybook-prs/4763 to see this build running in a browser. |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Migrates bpk-component-modal away from Flow/prop-types toward TypeScript-based typing, aligning modal prop validation with the TS codebase.
Changes:
- Replaces Flow annotations with TypeScript
typedefinitions for custom validators. - Introduces
ValidatorProps/Validatortypes and applies them totitlePropTypeandonClosePropType.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Visit https://backpack.github.io/storybook-prs/4763 to see this build running in a browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bpk-component-modalfrom JavaScript to TypeScriptprop-typeswith TypeScript interfacesdefaultPropsto ES6 destructure defaults.jssource/test/story files to.tsx/.tsCloses #4750