Skip to content

[bpk-component-scrollable-calendar] Migrate remaining JS file to TypeScript#4765

Open
Gert-Jan Vercauteren (gert-janvercauteren) wants to merge 5 commits into
mainfrom
ts-migration/bpk-component-scrollable-calendar
Open

[bpk-component-scrollable-calendar] Migrate remaining JS file to TypeScript#4765
Gert-Jan Vercauteren (gert-janvercauteren) wants to merge 5 commits into
mainfrom
ts-migration/bpk-component-scrollable-calendar

Conversation

@gert-janvercauteren

Copy link
Copy Markdown
Contributor

Summary

  • Migrates bpk-component-scrollable-calendar from JavaScript to TypeScript
  • Replaces prop-types with TypeScript interfaces
  • Converts defaultProps to ES6 destructure defaults
  • Removes Flow type annotations
  • Renames .js source/test/story files to .tsx/.ts

Closes #4752

…Script

Migrates bpk-component-scrollable-calendar from JavaScript to TypeScript as described in #4752.

- Replaced prop-types with TypeScript interfaces
- Converted defaultProps to ES6 destructure defaults
- Renamed .js source/test/story files to .tsx/.ts
- Removed Flow type annotations
- Preserved Apache 2.0 license headers

Closes #4752
Copilot AI review requested due to automatic review settings June 26, 2026 09:25
@skyscanner-backpack-bot

Copy link
Copy Markdown
Contributor

Visit https://backpack.github.io/storybook-prs/4765 to see this build running in a browser.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Migrates bpk-component-scrollable-calendar remaining JavaScript artifacts toward TypeScript by adding type annotations and replacing runtime prop validation with static typing.

Changes:

  • Adds TypeScript type annotations to date formatter helpers.
  • Introduces WeekDay typing for exported weekday arrays.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@skyscanner-backpack-bot

Copy link
Copy Markdown
Contributor

Visit https://backpack.github.io/storybook-prs/4765 to see this build running in a browser.

@skyscanner-backpack-bot

skyscanner-backpack-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against b28eb86

@skyscanner-backpack-bot

Copy link
Copy Markdown
Contributor

Visit https://backpack.github.io/storybook-prs/4765 to see this build running in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Non breaking change ts-conversion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bpk-component-scrollable-calendar] Migrate remaining JS file to TypeScript

2 participants