Revert "[WOODPECKER-4406] Migrate package manager from npm to pnpm"#4787
Merged
Conversation
Viktor Yang (viktor-yang)
approved these changes
Jul 2, 2026
Faye (Faye-Xiao)
approved these changes
Jul 2, 2026
Contributor
|
Visit https://backpack.github.io/storybook-prs/4787 to see this build running in a browser. |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Reverts the previous migration to pnpm by switching the monorepo back to npm workspaces and updating scripts, docs, and CI workflows accordingly.
Changes:
- Replace
pnpmcommands withnpm/npm ciacross scripts, docs, and GitHub Actions. - Move workspace configuration from
pnpm-workspace.yamlto rootpackage.jsonworkspaces. - Update Jest/node_modules handling to reflect npm’s node_modules layout rather than pnpm’s
.pnpmstructure.
Reviewed changes
Copilot reviewed 35 out of 38 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| token-sync/src/build-css.ts | Updates messaging and minor formatting while reverting to npm-based instructions. |
| token-sync/src/build-css-cli.ts | Updates inline docs to reference npm run commands. |
| token-sync/RUNBOOK.md | Reverts runbook commands from pnpm to npm. |
| token-sync/README.md | Reverts setup and usage docs from pnpm to npm. |
| pnpm-workspace.yaml | Removes pnpm workspace configuration. |
| packages/backpack-web/src/bpk-stylesheets/README.md | Reverts build guidance from pnpm to npm. |
| packages/backpack-web/src/bpk-component-floating-notification/src/BpkFloatingNotification.tsx | Minor refactor of timeout cleanup. |
| packages/backpack-web/package.json | Removes package-level devDependencies (now expected to be handled elsewhere with npm workspaces). |
| packages/backpack-web/jest.config.js | Adjusts transform ignore patterns for non-pnpm node_modules layout. |
| packages/backpack-adoption-guard/project.json | Replaces pnpm filtering with npm workspace commands. |
| package.json | Adds npm workspaces config, updates engines, replaces pnpm commands with npm, and adjusts dependency metadata. |
| libs/backpack-storybook-host/package.json | Changes workspace dependency specifiers and removes a devDependency. |
| libs/backpack-storybook-host/.storybook/webpack.config.js | Updates node_modules exclude regex to match npm layout. |
| decisions/imports-ts-suppressions.md | Reverts references from pnpm to npm. |
| DEV_RELEASE.md | Updates CI build steps from pnpm to npm. |
| CONTRIBUTING.md | Reverts contributor docs from pnpm to npm and clarifies workspaces live in root package.json. |
| AGENTS.md | Updates agent context commands to npm. |
| .specify/templates/tasks-template.md | Updates task template commands from pnpm to npm. |
| .specify/templates/plan-template.md | Updates package manager reference and minimum version. |
| .specify/scripts/bash/update-agent-context.sh | Updates suggested JS/TS commands from pnpm to npm. |
| .specify/memory/constitution.md | Updates supported tooling references from pnpm to npm. |
| .npmrc | Removes pnpm-related config and strictness settings; leaves registry only. |
| .gitignore | Stops ignoring package-lock.json; updates ignored debug log patterns. |
| .github/workflows/sync-figma-variables.yml | Switches token-fetch workflow from pnpm install/run to npm ci/run. |
| .github/workflows/release.yml | Switches release workflow from pnpm to npm and updates cache keys to package-lock.json. |
| .github/workflows/pr.yml | Reworks PR workflow caching/install steps around npm ci and node_modules caching. |
| .github/workflows/main.yml | Switches main workflow from pnpm to npm and updates caching keys. |
| .github/workflows/dev-release.yml | Switches dev-release workflow install/build from pnpm to npm and adjusts caching. |
| .github/workflows/backpack-adoption-guard-release.yml | Switches adoption-guard release workflows from pnpm to npm ci. |
| .github/workflows/_build.yml | Switches reusable build workflow from pnpm to npm and replaces pnpm caching/install steps. |
| .github/actions/figma-token-sync-pr/action.yml | Switches action step from pnpm to npm for CSS build. |
| .github/actions/figma-token-sync-pr/README.md | Updates action documentation from pnpm to npm. |
| .claude/skills/backpack-external-component-migration/SKILL.md | Updates required verification commands from pnpm to npm. |
| .claude/skills/backpack-code-review-checklist/agents/agent3-a11y.md | Updates CI reference from pnpm test to npm test. |
| .claude/guidelines/bpk-token-value-lookup.md | Updates prerequisite instruction from pnpm install to npm install. |
| .claude/guidelines/bpk-new-component-workflow.md | Updates build/check commands from pnpm to npm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
17
| "@skyscanner/backpack-web": "*", | ||
| "bpk-storybook-utils": "*" | ||
| } |
Comment on lines
+43
to
+49
| - name: Restore Cache | ||
| uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 | ||
| id: npm-cache | ||
| with: | ||
| path: | | ||
| node_modules/ | ||
| key: ${{ env.CACHE_NAME }}-${{ hashFiles('package-lock.json') }} |
Comment on lines
+108
to
+115
| - name: Restore npm Cache | ||
| uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 | ||
| id: npm-cache | ||
| with: | ||
| path: | | ||
| node_modules/ | ||
| packages/backpack-web/node_modules/ | ||
| key: ${{ env.CACHE_NAME }}-${{ hashFiles('package-lock.json', 'packages/backpack-web/package-lock.json') }} |
Comment on lines
34
to
+35
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
| run: npm ci |
| **Linting**: ESLint (@skyscanner/eslint-config-skyscanner), Stylelint | ||
| **Component Library**: Backpack Design System (Monorepo) | ||
| **Package Manager**: pnpm >=9.15.9 | ||
| **Package Manager**: npm >=10.7.0 |
| @@ -1,6 +1 @@ | |||
| registry=https://registry.npmjs.org/ | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4738