Skip to content

Conversation

@aleclorimer
Copy link
Contributor

Lazy loading of zigbee-fan sub-drivers and copyright updates.

@github-actions
Copy link

@github-actions
Copy link

Test Results

   71 files    477 suites   0s ⏱️
2 471 tests 2 471 ✅ 0 💤 0 ❌
4 236 runs  4 236 ✅ 0 💤 0 ❌

Results for commit 9147859.

@github-actions
Copy link

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-fan/src/configurations.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-fan/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-fan/src/fan-light/can_handle.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-fan/src/fan-light/init.lua 94%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 9147859

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move the configurations into the function where it is used, since it is only used at startup. That way it gets gc'd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants