Setup DistABLPLoader for GraphStore mode by kmontemayor2-sc · Pull Request #485 · Snapchat/GiGL

kmontemayor2-sc · 2026-02-11T18:37:03Z

Scope of work done

Support GS inputs and sampling for ABLP Loader
Fix some bugs in DistLoader to support "labeled homogeneous" mode
Add tests for iterating over both dataloader in with ABLP dataset

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

kmontemayor2-sc · 2026-02-11T19:58:36Z

/e2e_test

kmontemayor2-sc · 2026-02-11T19:58:43Z

/integration_test

kmontemayor2-sc · 2026-02-11T19:58:47Z

/unit_test_py

github-actions · 2026-02-11T19:58:53Z

GiGL Automation

@ 19:58:53UTC : 🔄 E2E Test started.

@ 21:23:22UTC : ✅ Workflow completed successfully.

github-actions · 2026-02-11T19:58:54Z

GiGL Automation

@ 19:58:54UTC : 🔄 Integration Test started.

@ 21:07:19UTC : ✅ Workflow completed successfully.

github-actions · 2026-02-11T19:59:00Z

GiGL Automation

@ 19:58:59UTC : 🔄 Python Unit Test started.

@ 21:10:08UTC : ✅ Workflow completed successfully.

mkolodner-sc

Thanks Kyle, left a few comments/questions

gigl/distributed/dist_ablp_neighborloader.py

kmontemayor2-sc · 2026-02-12T21:36:49Z

/integration_test

kmontemayor2-sc · 2026-02-12T21:36:54Z

/unit_test_py

github-actions · 2026-02-12T21:37:00Z

GiGL Automation

@ 21:37:00UTC : 🔄 Integration Test started.

@ 22:39:45UTC : ❌ Workflow failed.
Please check the logs for more details.

github-actions · 2026-02-12T21:37:10Z

GiGL Automation

@ 21:37:10UTC : 🔄 Python Unit Test started.

@ 21:44:13UTC : ❌ Workflow failed.
Please check the logs for more details.

kmontemayor2-sc · 2026-02-12T21:52:04Z

/unit_test_py

github-actions · 2026-02-12T21:52:16Z

GiGL Automation

@ 21:52:15UTC : 🔄 Python Unit Test started.

@ 23:04:55UTC : ✅ Workflow completed successfully.

kmontemayor2-sc · 2026-02-12T23:13:12Z

/integration_test

github-actions · 2026-02-12T23:13:24Z

GiGL Automation

@ 23:13:23UTC : 🔄 Integration Test started.

@ 24:01:43UTC : ❌ Workflow failed.
Please check the logs for more details.

kmontemayor2-sc · 2026-02-13T00:05:54Z

/integration_test

github-actions · 2026-02-13T00:06:05Z

GiGL Automation

@ 24:06:05UTC : 🔄 Integration Test started.

@ 01:59:33UTC : ❌ Workflow failed.
Please check the logs for more details.

kmontemayor2-sc · 2026-02-13T02:34:25Z

/integration_test

github-actions · 2026-02-13T02:34:40Z

GiGL Automation

@ 02:34:39UTC : 🔄 Integration Test started.

@ 04:06:55UTC : ❌ Workflow failed.
Please check the logs for more details.

gigl/distributed/dist_ablp_neighborloader.py

gigl/utils/sampling.py

gigl/distributed/graph_store/remote_dist_dataset.py

gigl/utils/sampling.py

tests/test_assets/test_case.py

tests/integration/distributed/graph_store/graph_store_integration_test.py

mkolodner-sc

Thanks Kyle! Mostly LGTM, just a few small questions/comments

gigl/distributed/graph_store/remote_dist_dataset.py

gigl/distributed/dist_ablp_neighborloader.py

svij-sc

Stamping (since two approvals are needed); I'm sure it was discussed somewhere, and there is good reason, but the PR is quite large.
I will leave @mkolodner-sc to do the full review here.

gigl/distributed/graph_store/remote_dist_dataset.py

mkolodner-sc

Thanks Kyle!

kmonte added 2 commits February 11, 2026 18:35

Setup DistABLPLoader for GraphStore mode

7d0d8be

fixes

3c3bf1b

mkolodner-sc reviewed Feb 11, 2026

View reviewed changes

kmonte added 3 commits February 11, 2026 21:41

address comments

841a9fd

with timing

0669562

maybe works?

b488f7f

fixes

9198ecb

kmonte added 2 commits February 12, 2026 23:09

Merge branch 'main' into kmonte/gs-for-ablp

5cdee46

remove for now

8ad09ec

maybe?

347f359

Update test_case.py

8b7dd29

revert some stuff

0d5ff13

kmonte added 5 commits February 14, 2026 01:38

hmmm

8cbcf27

tmp

8838ec4

Merge branch 'main' into kmonte/gs-for-ablp

a65dab2

werkz

90cfc62

fix

2a4d4e4

kmontemayor2-sc commented Feb 17, 2026

View reviewed changes

kmonte added 2 commits February 17, 2026 17:28

fix for dist loader

8e882d0

fix

32f9ab6

mkolodner-sc reviewed Feb 18, 2026

View reviewed changes

fixes

203487c

svij-sc approved these changes Feb 18, 2026

View reviewed changes

mkolodner-sc reviewed Feb 18, 2026

View reviewed changes

gigl/distributed/graph_store/remote_dist_dataset.py Show resolved Hide resolved

fix

d939e0b

mkolodner-sc approved these changes Feb 18, 2026

View reviewed changes

kmontemayor2-sc marked this pull request as ready for review February 18, 2026 19:22

kmontemayor2-sc requested review from nshah-sc, xgao4-sc, yliu2-sc and zfan3-sc as code owners February 18, 2026 19:22

kmontemayor2-sc added this pull request to the merge queue Feb 18, 2026

kmontemayor2-sc removed this pull request from the merge queue due to a manual request Feb 18, 2026

log

5275fb3

kmontemayor2-sc enabled auto-merge February 18, 2026 19:31

kmontemayor2-sc added this pull request to the merge queue Feb 18, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2026

fix

d8f32a1

kmontemayor2-sc added this pull request to the merge queue Feb 18, 2026

Merged via the queue into main with commit caa29dc Feb 18, 2026
6 checks passed

kmontemayor2-sc deleted the kmonte/gs-for-ablp branch February 18, 2026 22:45

Conversation

kmontemayor2-sc commented Feb 11, 2026

Uh oh!

kmontemayor2-sc commented Feb 11, 2026

Uh oh!

kmontemayor2-sc commented Feb 11, 2026

Uh oh!

kmontemayor2-sc commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

github-actions bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

github-actions bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

mkolodner-sc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kmontemayor2-sc commented Feb 12, 2026

Uh oh!

kmontemayor2-sc commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

kmontemayor2-sc commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

kmontemayor2-sc commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

kmontemayor2-sc commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

kmontemayor2-sc commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GiGL Automation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkolodner-sc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026 •

edited

Loading

github-actions bot commented Feb 11, 2026 •

edited

Loading

github-actions bot commented Feb 11, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 12, 2026 •

edited

Loading

github-actions bot commented Feb 13, 2026 •

edited

Loading

github-actions bot commented Feb 13, 2026 •

edited

Loading

svij-sc left a comment •

edited

Loading