Post milestone3m#632
Open
SharonStrats wants to merge 84 commits intomainfrom
Open
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This reverts commit 86b7160.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors several legacy panes from .js to .ts, extracts/normalizes CSS into dedicated stylesheets, and expands the Social pane with friend request triage plus a new “Requests” tab and updated header/actions UI.
Changes:
- Added friendship triage utilities and a new “Requests” section/tab in the Social pane, with UI refresh after relationship changes.
- Migrated multiple panes (e.g., N3, RDFXML, data content, image, default, form) to TypeScript and introduced pane-specific CSS files for styling/mobile layout improvements.
- Updated dev/build wiring (tsconfig paths, dev loader import) and adjusted tests to match updated styling behaviors.
Reviewed changes
Copilot reviewed 42 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| typings/declarations.d.ts | Adds ambient typings for solid-ui-button and module stubs used by new UI code. |
| tsconfig.dev.json | Adjusts dev TypeScript path mappings for symlinked dependencies. |
| test/unit/social/triage.test.ts | Adds unit tests for friendship triage and loading behavior. |
| test/unit/outline/manager.test.ts | Updates style assertions to use object-based expectations. |
| src/ui/pane.js | Imports form pane CSS to ensure styles are loaded. |
| src/styles/utilities.css | Introduces shared CSS variables used by refactored panes. |
| src/styles/tabbedtab.css | Removes large blocks of legacy pane styling migrated elsewhere. |
| src/social/triage.ts | Implements triage + best-effort loading of related profile docs for requests detection. |
| src/social/socialSections.ts | Refactors header actions container, mutual UI, and adds a Requests section renderer. |
| src/social/socialPane.ts | Adds Requests tab/panel, relationship UI refresh logic, and environment data attributes. |
| src/social/socialPane.css | Updates social layout/styles, adds Requests styling, and improves mobile responsiveness. |
| src/social/icons.ts | Tweaks edit icon sizing and adds plus/trash icons for the profile links editor UI. |
| src/social/editProfileDetails.ts | Switches to solid-ui-button and supports multiple links per field with add/remove UI. |
| src/schedule/schedulePane.ts | Refactors scheduling pane for stronger typing and moves inline styles to CSS. |
| src/schedule/schedulePane.css | New stylesheet supporting schedule pane layout and mobile adjustments. |
| src/registerPanes.js | Updates pane imports (extensionless) and points to new TS pane modules. |
| src/RDFXMLPane.ts | Ports RDFXML pane to TS and adds responsive rendering + stylesheet usage. |
| src/RDFXMLPane.js | Removed legacy JS implementation in favor of TS port. |
| src/RDFXMLPane.css | New RDFXML pane stylesheet (including mobile wrapping behavior). |
| src/pad/padPane.ts | Replaces inline style with a CSS class for the “new instance” message. |
| src/pad/padPane.css | Adds new class and normalizes CSS units (em → rem in a few places). |
| src/outline/manager.js | Improves auth-related error messaging shown in the outline UI. |
| src/n3Pane.ts | Ports N3 pane to TS with better mobile wrapping/indent behavior. |
| src/n3Pane.js | Removed legacy JS implementation in favor of TS port. |
| src/n3Pane.css | New N3 pane stylesheet (including mobile line wrap indentation). |
| src/internal/internalPane.ts | Moves inline styles to CSS classes and cleans up button class handling. |
| src/internal/internalPane.css | New internal pane stylesheet. |
| src/imagePane.ts | Ports image pane to TS and introduces a dedicated stylesheet. |
| src/imagePane.js | Removed legacy JS implementation in favor of TS port. |
| src/imagePane.css | New image pane stylesheet. |
| src/humanReadablePane.ts | Refactors human-readable rendering with stronger types + moves styles to CSS. |
| src/humanReadablePane.css | New stylesheet for markdown/plaintext/iframe rendering, incl. mobile behavior. |
| src/form/pane.ts | Ports form pane to TS, adds mobile textarea row tagging + CSS import. |
| src/form/pane.js | Removed legacy JS implementation in favor of TS port. |
| src/form/formPane.css | New stylesheet extracted from legacy global CSS. |
| src/defaultPane.ts | Ports default pane to TS, adds environment attributes, and improves literal handling. |
| src/defaultPane.css | New stylesheet for default pane layout (including mobile layout rules). |
| src/dataContentPane.ts | Ports data content pane to TS and updates nested table shading logic. |
| src/dataContentPane.js | Removed legacy JS implementation in favor of TS port. |
| src/dataContentPane.css | New stylesheet for data content pane, including mobile rules and theme vars. |
| README.md | Updates wording and adds additional implementation notes. |
| package-lock.json | Updates lockfile content (includes a new extraneous local-path entry). |
| dev/loader.ts | Switches contacts-pane registration to dynamic import in the dev loader. |
| dev/dev-mash.css | Removes legacy pane CSS now covered by pane-specific stylesheets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
3
to
10
| "compilerOptions": { | ||
| "rootDir": ".", | ||
| "baseUrl": ".", | ||
| "preserveSymlinks": true, | ||
| "paths": { | ||
| "rdflib": ["node_modules/rdflib"], | ||
| "solid-logic": ["node_modules/solid-logic"], | ||
| "solid-ui": ["node_modules/solid-ui"] | ||
| "rdflib": ["./node_modules/rdflib"], | ||
| "solid-logic": ["./node_modules/solid-logic"], | ||
| "solid-ui": ["./node_modules/solid-ui"] | ||
| } |
Comment on lines
+549
to
+553
| refreshRelationshipUi = function () { | ||
| headerControls = { | ||
| ...headerControls, | ||
| showAddFriendAction: shouldShowHeaderAddFriendAction(headerControls.viewerMode) | ||
| } |
Comment on lines
+123
to
+136
| * GPT-5.3-Codex in GitHub Copilot: This is the comment I got from copilot, but suggested fix remove the dark class as well The nested table shading logic checks UI.utils.ancestor(newTable, 'TABLE') immediately after creating newTable, but at that moment newTable typically has no | ||
| parent in the DOM yet. This makes parentTable null and will | ||
| always apply dataContentPaneNestedLight, preventing the | ||
| intended alternating light/dark nested backgrounds. | ||
| Consider assigning the class after appending newTable into | ||
| its parent table, or pass the parent table (or current nesting depth) into objectTree() so the decision can be made reliably. can you help me fix this without removing the dark altering | ||
|
|
||
| * GPT-5.4 Model: Make this (n3Pane) look good on mobile by indenting the lines that wrap. | ||
|
|
||
| * GPT-5.4 Model: Generate TypeScript types for the default pane. | ||
|
|
||
| * GPT-5.4 Model: Add a compatibility shim in the form pane for mixed `ui:Group` plus field typing. | ||
|
|
||
| * AI GPT-5.4 Model: After friend is added when mutual checkbox is checked refresh mutual and header sections */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor... plus social