Add cross-OS S3 restore regression test#84
Conversation
Linux saves a workspace file to S3 with enableCrossOsArchive=true; a dependent Windows job must restore the same cache entry. Reproduces runs-on/cache v5.0.7 restoreImpl not passing enableCrossOsArchive on the S3 restore path.
|
|
CI failed: The CI pipeline failed due to a formatting error in CLAUDE.md caught by markdownlint and a cache miss in the newly added cross-OS S3 restore regression test.OverviewTwo distinct issues are blocking the PR: a linting violation in the documentation and an incorrectly configured regression test that fails when the cache is missing. FailuresMarkdown Linting Error (confidence: high)
Cross-OS S3 Regression Test Failure (confidence: high)
Summary
Code Review ✅ ApprovedRegression test suite added to verify S3 cross-OS cache restoration between Linux and Windows. No issues found. Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |



Summary
test-s3-cache-cross-os-save-linuxandtest-s3-cache-cross-os-restore-windowsjobs totest-action.yml.cross-os-cache-test.txtto S3 withenableCrossOsArchive: truecache-hit=trueand file contentimport-github-cache: falseon both jobs so GitHub cache fallback cannot mask an S3 missContext
Reproduces runs-on/cache v5.0.7 bug:
enableCrossOsArchiveis not passed tocustom.restoreCache()on the S3 restore path, so Windows lookups use a different version hash than Linux saves.Test plan
test-s3-cache-cross-os-save-linuxpassestest-s3-cache-cross-os-restore-windowsfails on currentruns-on/cachepin (expected until pin bump)runs-on/cacheto a fixed version, both jobs pass