Skip to content

Regression in 0.6.2? #43

Open
Open

Description

@chrispbailey

The move away from env.clone on this line:https://github.com/SortableJS/angular-legacy-sortablejs/compare/8e2f1c97897da91ab373537b47551cabfab2e078..master#diff-fd07c4295c44d1bcf1aaf3d5862c0afbL115 caused an issue dragging and dropping between multiple sortable lists. The source list's order gets shuffled around (see attached video).

sortable_bug

Activity

  1. changed the title [-]Regression in 0.6.2[/-] [+]Regression in 0.6.2?[/+] on Dec 19, 2018
  2. samjacobclift commented on Dec 20, 2018

    @samjacobclift
    Contributor

    hmm someone did request this to be changed to that, is the issue caused because the check fails or because it passes?

    perhaps we could change it to an or

    if ((evt.clone) || (Sortable.active && Sortable.active.lastPullMode === 'clone')) {
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions