Skip to content

fix: v0.5.44 — Docker license-label fix from v0.5.43 didn't reach the published image #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SoundMatt merged 1 commit into from
Jul 27, 2026
Merged

fix: v0.5.44 — Docker license-label fix from v0.5.43 didn't reach the published image #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ jobs:
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=raw,value=latest
# metadata-action can't detect an SPDX license from the GitHub API
# and defaults org.opencontainers.image.licenses to NOASSERTION,
# which silently overrides the correct value the Dockerfile's own
# LABEL sets (matching keys passed to build-push-action win over
# the Dockerfile). Override it explicitly so the published image
# actually carries "MPL-2.0" (see issue #62 item 1).
labels: |
org.opencontainers.image.licenses=MPL-2.0

- name: Read spec version from version.h
id: version
Expand Down
17 changes: 17 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,23 @@ and the project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.

## [Unreleased]

## v0.5.44 — 2026-07-27

### Fixed
- **The v0.5.43 Docker license-label fix didn't actually reach the published
image.** `docker/metadata-action` auto-generates a set of OCI labels
(including `org.opencontainers.image.licenses`, defaulted to
`NOASSERTION` because it can't detect an SPDX license from the GitHub
API) and `docker-publish.yml` passed that full label set to
`build-push-action`, which overrides same-key `LABEL`s declared in the
Dockerfile. So the real `ghcr.io/soundmatt/c-fusa:0.5.43` image still
shipped `licenses=NOASSERTION`, silently undoing the Dockerfile fix from
v0.5.43 (#62 item 1). Fixed by passing `org.opencontainers.image.licenses:
MPL-2.0` as a custom label to `docker/metadata-action` itself, which
overrides its own auto-generated value before it ever reaches
`build-push-action`. Caught by manually inspecting the published v0.5.43
image's labels via the Docker Publish workflow logs after tagging.

## v0.5.43 — 2026-07-27

Fixes from a 2026-07-27 cross-repo audit (issues #62, #63).
Expand Down
4 changes: 2 additions & 2 deletions include/cfusa/version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

#define CFUSA_VERSION_MAJOR 0
#define CFUSA_VERSION_MINOR 5
#define CFUSA_VERSION_PATCH 43
#define CFUSA_VERSION_STRING "0.5.43"
#define CFUSA_VERSION_PATCH 44
#define CFUSA_VERSION_STRING "0.5.44"
#define CFUSA_SCHEMA_VERSION "1.11.0"
/* Bumped from 1.10.12 to match the x-FuSa master spec's additive §1.4.1
* "requirement annotation completeness" MINOR bump (issue #62 item 3). The
Expand Down
Loading