fix(ci): add --strict to the relay interop gate - #65
Merged
Conversation
The relay interop gate omitted --strict, while the relay conform gate immediately above it passes --strict. --strict makes relay interop treat a binary that lacks `convert` as a failure rather than a skip (cmd/relay/interop.go in the RELAY repo). Without it, a future accidental removal or rename of cantool's `convert` support would silently downgrade the interop check to a skip instead of failing CI. Verified locally with the pinned relay v1.10.0 binary: both `relay conform --strict` and `relay interop --protocol CAN --strict` pass against cmd/cantool (PASS, EQUIVALENT for every CAN golden vector). Closes #55 Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
`ci.yml`'s `relay interop` gate omitted `--strict`, while the `relay conform` gate immediately above it passes `--strict`. `--strict` treats a binary that lacks `convert` as a failure rather than a skip. Without it, a future accidental removal or rename of `cantool`'s `convert` support would silently downgrade the interop check to a skip instead of failing CI — a defense-in-depth gap, not a currently-active false green (today `cantool` both advertises and implements `convert`).
Fix
Add `--strict` to the `relay interop` invocation so a future capability regression fails CI instead of silently skipping.
Testing
Verified locally with the pinned `relay` v1.10.0 binary against `cmd/cantool`:
Closes #55