feat: v0.33.0 — maximize tests and requirements - #40
Merged
Conversation
Audit-driven improvements addressing all six findings (P0–P2): P0 — REQ-TRACE008: cmd/gofusa/cmd_v032_test.go adds six CLI-level tests for runTraceHLRLLR covering ExitOK with no violations, ExitGateFail for orphaned LLR, ExitGateFail for uncovered HLR, nil-summary path, and two end-to-end --strict-hlr-llr integration tests. P1 — REQ-VERIFY006/007: registered in .fusa-reqs.json (verify.Save and verify.Load); //fusa:test annotations added to TestSaveAndLoad_Roundtrip in verify/verify_test.go. P1 — REQ-QUALIFY005/006: registered in .fusa-reqs.json (qualify.Load and qualify.BuiltinCases); //fusa:test annotations added to TestSaveAndLoad_Roundtrip and TestBuiltinCases_NonEmpty in qualify/qualify_test.go. P2 — REQ-COV015: three cmd-level tests for runCoverage --mcdc: missing --mcdc-file (ExitUsage), below-threshold (ExitGateFail), fully covered (ExitOK). P2 — REQ-QUALIFY007/008: two cmd-level tests for runQualify with new flags; TestRunQualify_NewFlags_PopulateReport reads the saved JSON and asserts all six new fields; TestRunQualify_NoFlags_DefaultsPopulateStdout checks default badge output. P2 — renderMarkdown HLRLLRSummary: TestRender_Markdown_HLRLLRSummary in trace/trace_test.go exercises the v0.32.0 HLR/LLR summary table block. P2 — coverage.req() false branch: TestRenderText_DALD_ReqHelperNoBranch renders with DAL-D (no required metrics) to cover req(false) → "no". Four new requirements added to .fusa-reqs.json: REQ-VERIFY006, REQ-VERIFY007, REQ-QUALIFY005, REQ-QUALIFY006. Version bumped to v0.33.0. Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit-driven improvements addressing all six findings (P0–P2) from the go-FuSa code audit:
cmd/gofusa/cmd_v032_test.go— six CLI-level tests for therunTraceHLRLLRdispatch path: ExitOK with no violations, ExitGateFail for orphaned LLR, ExitGateFail for uncovered HLR, nil-summary path, and two--strict-hlr-llrend-to-end integration tests..fusa-reqs.json;//fusa:testannotations added toTestSaveAndLoad_Roundtripinverify/verify_test.go..fusa-reqs.json;//fusa:testannotations added toTestSaveAndLoad_RoundtripandTestBuiltinCases_NonEmptyinqualify/qualify_test.go.runCoverage --mcdccmd-level tests: missing--mcdc-file(ExitUsage), below-threshold (ExitGateFail), fully covered (ExitOK).runQualifycmd-level tests exercising all six new flags; asserts populated fields in saved JSON report.TestRender_Markdown_HLRLLRSummaryintrace/trace_test.go.TestRenderText_DALD_ReqHelperNoBranchincoverage/coverage_test.go.Four new requirements added to
.fusa-reqs.json: REQ-VERIFY006, REQ-VERIFY007, REQ-QUALIFY005, REQ-QUALIFY006. Version bumped to v0.33.0.Test plan
go build ./...— cleango vet ./...— cleango test ./...— all 43 packages passcmd/gofusa/cmd_v032_test.gocover all P0/P2 paths//fusa:testannotations present on existing tests for P1 requirements