Migrate from svelte-kit package to @sveltejs/package#13
Open
markfswe wants to merge 1 commit intoSplidejs:masterfrom
Open
Migrate from svelte-kit package to @sveltejs/package#13markfswe wants to merge 1 commit intoSplidejs:masterfrom
markfswe wants to merge 1 commit intoSplidejs:masterfrom
Conversation
|
@NaotoshiFujita is it good to merge? 👍 |
Author
|
Unlucky splide is silent for ~4 years :( it looked promising |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#12
Description
See sveltejs/kit#8922 for the information about required updates.
What I did in the PR:
npm i -D @sveltejs/packagenpx svelte-migrate packageNot sure, but maybe additional changes can be made to this PR.. I have never worked on publishing svelte packages and actually any types of packages. What I think is that maybe
.npmignorecan be added, which would list files which are not needed for a package to work, at least.githubfolder? What do you think?