Update wisp to v0.5.8 (epoll recv-on-freed-Conn crash fix)#4
Closed
kwsantiago wants to merge 1 commit into
Closed
Conversation
Author
|
Superseded by the v0.5.9 update, which folds in this v0.5.8 epoll fix plus the v0.5.9 shutdown-buffer fix so it can be sideloaded once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the packaged wisp from v0.5.7 to v0.5.8.
Fixes a SIGSEGV that hit the relay every few hours during normal operation under connection churn: http.zig's epoll worker could free a finished connection while the event loop still had a pending read event for it, so the next read dereferenced freed memory (getState on a null/recycled connection). The pinned http.zig now removes the fd from the event loop and closes it on the loop thread before the connection is recycled. Storage was never at risk.
Pinned to a temporary privkeyio http.zig fork; upstream PR karlseguin/http.zig#216, will repoint to upstream in a follow-up once merged (privkeyio/wisp#120, #123).
Dockerfile:WISP_VERSIONv0.5.7 -> v0.5.8,WISP_COMMIT-> c820359680262b0adea5506d41c9d73b4cb6bcc6current.ts: version 0.5.8:0 + release notesBuilt locally:
wisp_x86_64.s9pk, ReleaseSafe, baseline CPU.