Add "Set start and go to next" shortcut (SE4 parity, #12165)#12199
Merged
Conversation
SE4 had a "Set start and go to next" command (MainAdjustSetStartAndGotoNext) that stamps the current video position as the selected line's start time and advances to the next line - a core part of the rapid lyric/LRC syncing workflow. SE5 had "Set start" and "Set end and go to next" but not this one. Add WaveformSetStartAndGoToNextCommand (mirrors WaveformSetStart's start-only, ASSA-multi-select-aware timestamping plus the go-to-next from WaveformSetEndAndGoToNext), register it in the shortcut list, and map the SE4 key so imported SE4 configs pick it up. Left unbound by default so users assign their own key. English UI string added. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12165
Analysis: the shortcut is genuinely missing
SE4 has a "Set start and go to next" adjust command (config key
MainAdjustSetStartAndGotoNext) — it stamps the current video position as the selected line's start time and immediately advances selection to the next line. It was a core part of the rapid lyric/LRC syncing workflow.SE5 has the two siblings —
WaveformSetStartCommand("Set start", F11) andWaveformSetEndAndGoToNextCommand("Set end and go to next", F10) — but not "Set start and go to next". Confirmed absent fromShortcutsMainand the SE4 importer map. So the report is correct.Fix
WaveformSetStartAndGoToNextinMainViewModel. It mirrorsWaveformSetStart(start-only timestamp, ASSA multi-select aware, guards against setting start past end to avoid negative duration viaSetStartTimeOnlywhich keeps the end fixed) and then advances withSelectAndScrollToRow(idx + 1)likeWaveformSetEndAndGoToNext.ShortcutsMain(command→label lookup +AddShortcut) so it shows up in the shortcut configuration UI under General.MainAdjustSetStartAndGotoNext→WaveformSetStartAndGoToNextCommand, so users importing their SE4 shortcut config get it wired automatically.SetStartAndGoToNext = "Set start and go to next"added toLanguageGeneral.csandEnglish.json.Left unbound by default (like many sibling commands) so it can't collide with an existing default; the user assigns their preferred key in Options → Shortcuts.
Testing
Se4ShortcutsImporterMapTests.EveryMappedSe4ShortcutTargetsARegisteredCommandpasses — the new SE4 mapping targets a registered command.🤖 Generated with Claude Code