DOCS: Fix pytest setup command#11
Open
tomzhengy wants to merge 1 commit intoSynthesisLab:mainfrom
Open
Conversation
tomzhengy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to JOSS review openjournals/joss-reviews#10470
The README test commands need to tell reviewers to install the development dependencies before running pytest:
uv sync --extra dev uv run python -m pytest tests/ -m "not slow" -vI added the development sync step to the Testing section and kept the test commands explicit so a clean checkout has the required pytest dependencies before running the suite.
I checked this locally with
uv sync --extra devanduv run python -m pytest tests/ -m "not slow" -q; the non-slow suite passed with 51 tests.Please edit this PR and/or clarify if needed!