CHORE: Add benchmark extra#12
Open
tomzhengy wants to merge 1 commit intoSynthesisLab:mainfrom
Open
Conversation
tomzhengy
force-pushed
the
benchmark-extra
branch
from
9b6568d to
95067ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to JOSS review openjournals/joss-reviews#10470
compare_sb3.pyimportsstable_baselines3, but the default project environment does not install that benchmark dependency.I added a dedicated
benchmarkoptional extra and updated the README benchmark command:I kept
benchmarkout of the broadallextra so routine.[all]installs do not pull in SB3/Torch unless the benchmark is explicitly requested.I checked this locally with
uv sync --extra alland confirmedstable_baselines3was not installed, then ranuv sync --extra benchmarkand confirmedstable_baselines3,matplotlib, andseabornimport successfully.Please edit this PR and/or clarify if needed!