DOCS: Fix dqn agent example#13
Open
tomzhengy wants to merge 1 commit intoSynthesisLab:mainfrom
Open
Conversation
cbe3d5a to
ae27efa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to JOSS review openjournals/joss-reviews#10470
The README policy-representation examples used agent registry keys that do not match the implemented
make_agentregistry:I updated those examples to the registered keys
mlp/bool,mlp/dt, anddqn/mlp.The DQN example also used
layers, butDQNAgentreadsq_layers. I updated the config key so the example matches the current public API.I checked this locally by constructing
mlp/bool,mlp/dt, anddqn/mlpagents, then runningagent.init(...)andagent.policy(...)on a CartPole observation for each.Please edit this PR and/or clarify if needed!