Skip to content

DOCS: Fix dqn agent example#13

Open
tomzhengy wants to merge 1 commit intoSynthesisLab:mainfrom
tomzhengy:fix-dqn-readme-example
Open

DOCS: Fix dqn agent example#13
tomzhengy wants to merge 1 commit intoSynthesisLab:mainfrom
tomzhengy:fix-dqn-readme-example

Conversation

@tomzhengy
Copy link
Copy Markdown

@tomzhengy tomzhengy commented Apr 29, 2026

Related to JOSS review openjournals/joss-reviews#10470


  1. The README policy-representation examples used agent registry keys that do not match the implemented make_agent registry:

    make_agent("boolean/mlp", ...)
    make_agent("dt/mlp", ...)
    make_agent("dqn", ...)

    I updated those examples to the registered keys mlp/bool, mlp/dt, and dqn/mlp.

  2. The DQN example also used layers, but DQNAgent reads q_layers. I updated the config key so the example matches the current public API.

I checked this locally by constructing mlp/bool, mlp/dt, and dqn/mlp agents, then running agent.init(...) and agent.policy(...) on a CartPole observation for each.

Please edit this PR and/or clarify if needed!

@tomzhengy tomzhengy force-pushed the fix-dqn-readme-example branch from cbe3d5a to ae27efa Compare April 29, 2026 23:00
@tomzhengy tomzhengy marked this pull request as ready for review April 29, 2026 23:06
@tomzhengy tomzhengy changed the title docs: fix dqn agent example DOCS: Fix dqn agent example Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant