Fix: extend adminGroup ROLE_ADMIN assignment to X509 cert auth#70
Open
milne1282 wants to merge 1 commit into
Open
Fix: extend adminGroup ROLE_ADMIN assignment to X509 cert auth#70milne1282 wants to merge 1 commit into
milne1282 wants to merge 1 commit into
Conversation
The adminGroup LDAP config attribute was only checked in OAuthAuthenticator (OAuth/JWT token flow), but not in X509Authenticator (certificate-based auth on the HTTPS connector). As a result, users authenticating via X.509 client certificate were never granted ROLE_ADMIN based on LDAP group membership, even when correctly configured. Add the same adminGroup check to X509Authenticator's LDAP group lookup path, mirroring the existing logic in OAuthAuthenticator. After LDAP group info is retrieved and processed through groupPrefix and groupNameExtractorRegex, if the resulting group set contains the configured adminGroup value, ROLE_ADMIN is added to the user's authorities. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adminGroup LDAP config attribute was only checked in OAuthAuthenticator (OAuth/JWT token flow), but not in X509Authenticator (certificate-based auth on the HTTPS connector). As a result, users authenticating via X.509 client certificate were never granted ROLE_ADMIN based on LDAP group membership, even when correctly configured.
Add the same adminGroup check to X509Authenticator's LDAP group lookup path, mirroring the existing logic in OAuthAuthenticator. After LDAP group info is retrieved and processed through groupPrefix and groupNameExtractorRegex, if the resulting group set contains the configured adminGroup value, ROLE_ADMIN is added to the user's authorities.