[FIX] model provider compatibility with Megatron-LM #1500
+31
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using recent Megatron-LM versions (since Dec 10, 2025, NVIDIA/Megatron-LM#2608), model initialization fails with
unexpected keyword argument 'pg_collection'orconfigbecause the upstream megatronget_modelinterface now passes these arguments explicitly. This causesconvert_hf_to_torch_dist.pyto fail.from megatron
Fix
wrapped_model_providerto dynamically inspect signatures and only passpg_collection,vp_stage, orconfigif the custom function accepts them.model_providerto acceptpg_collectionandconfigand forwardpg_collectiontoGPTModelkwargs for correct distributed initialization.Related