Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/react/projects/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@tanstack/router-plugin": "^1.159.5",
"@trpc/client": "^11.10.0",
"@trpc/server": "^11.10.0",
"better-auth": "^1.4.18",
"better-auth": "^1.3.4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify manifest vs lockfile spec and resolved entries for better-auth
rg -n '"better-auth"\s*:' examples/react/projects/package.json
fd pnpm-lock.yaml --exec rg -n 'better-auth(@|:)' {}

Repository: TanStack/db

Length of output: 318


🌐 Web query:

What are the patched version ranges for better-auth for CVE-2025-61928, GHSA-569q-mpph-wgww, and GHSA-x732-6j76-qmhm, and do they require >=1.4.5?

💡 Result:

Vulnerability Vulnerable (affected) better-auth versions Patched / fixed better-auth versions Requires >= 1.4.5?
CVE-2025-61928 < 1.3.26 >= 1.3.26 No (1.3.26 is sufficient) [1]
GHSA-569q-mpph-wgww < 1.4.2 >= 1.4.2 No (1.4.2 is sufficient) [2]
GHSA-x732-6j76-qmhm < 1.4.5 >= 1.4.5 Yes [3]

If you upgrade to better-auth >= 1.4.5, you’ll be patched for all three. [3]

Sources: [1] [2] [3]


Keep better-auth ≥ 1.4.5 to fix all three advisories; resolve lockfile mismatch.

At Line 29, the change to ^1.3.4 introduces a regression. While this floor fixes CVE-2025-61928 (patched ≥ 1.3.26) and GHSA-569q-mpph-wgww (patched ≥ 1.4.2), it leaves GHSA-x732-6j76-qmhm vulnerable (requires ≥ 1.4.5). Given the PR explicitly references these advisories, the version floor should be at least ^1.4.5.

Additionally, the lockfile currently contains both 1.4.18 and 1.3.4 entries but the manifest specifies ^1.3.4, causing misalignment that must be resolved.

Proposed fix
-    "better-auth": "^1.3.4",
+    "better-auth": "^1.4.5",

Then regenerate the lockfile to match.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"better-auth": "^1.3.4",
"better-auth": "^1.4.5",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@examples/react/projects/package.json` at line 29, Update the better-auth
dependency in the manifest from "^1.3.4" to "^1.4.5" so the package.json floor
addresses GHSA-x732-6j76-qmhm and the other advisories, then regenerate the
lockfile (npm/yarn/pnpm lock) so the lock reflects a single resolved version
(remove/replace the 1.3.4 entry and ensure only the 1.4.x entry, e.g., 1.4.18,
is present); target the package.json "better-auth" entry and the repo
lockfile(s) to keep them consistent.

"dotenv": "^17.2.4",
"drizzle-orm": "^0.45.1",
"drizzle-zod": "^0.8.3",
Expand Down
Loading