React Native Shopping List demo app#1357
Open
kevin-dp wants to merge 189 commits intokevin/includesfrom
Open
Conversation
…ion key collision When multiple parents share the same correlation key but have different parent-referenced filter values, child collections were incorrectly shared. Fix by keying child collections by (correlationKey, parentFilterValues) composite, and using composite child keys in the D2 stream to prevent collisions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ss-window sync Add ElectronCollectionCoordinator using BroadcastChannel + Web Locks for leader election and cross-window coordination in Electron renderer windows. Wire coordinator into renderer persistence via setAdapter(), add getStreamPosition to the IPC protocol, and export from package index. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reproduces the bug where grouped ordering for limit uses the raw correlation key instead of the composite routing key, causing parents that share a correlation key but differ on parent-referenced filters to have their children merged before the limit is applied. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The includesGroupKeyFn for orderBy + limit/offset was grouping by raw correlationKey, causing parents sharing a correlation key but differing on parent-referenced filters to have their children merged before the limit was applied. Use the same composite key as the routing layer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…at both levels When both the child and grandchild includes use parent-referencing filters, the grandchild collection comes back empty because the nested routing index uses a different key than the nested buffer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…fer keys The nested routing index was keyed by raw correlationKey while nested buffers use computeRoutingKey(correlationKey, parentContext). This mismatch caused drainNestedBuffers lookups to fail, leaving grandchild collections empty when parent-referencing filters exist at both levels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…filters Verifies that composite routing keys work at arbitrary nesting depth, not just the first two levels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…llection Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ld cleanup Two fixes for when multiple parents share the same correlation key: 1. Add reduce operator on parentKeyStream to clamp multiplicities to 1, preventing the inner join from producing duplicate child entries that cause incorrect deletions when one parent is removed. 2. In Phase 5, only delete child registry entry when the last parent referencing it is removed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These routing properties leak into user-visible results when the child
query uses a spread select (e.g. { ...i }).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Brings in toArray() for includes subqueries, used by the shopping list demo to materialize child item arrays for reactive count display. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Brings in support for aggregates (e.g. count) in includes subqueries, enabling per-parent aggregate computation in the shopping list demo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: b318908 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦋 Changeset detectedLatest commit: 6d89a7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-browser-wa-sqlite-persisted-collection
@tanstack/db-cloudflare-do-sqlite-persisted-collection
@tanstack/db-electron-sqlite-persisted-collection
@tanstack/db-ivm
@tanstack/db-node-sqlite-persisted-collection
@tanstack/db-react-native-sqlite-persisted-collection
@tanstack/db-sqlite-persisted-collection-core
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: +3.17 kB (+3.28%) Total Size: 99.8 kB
ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.7 kB ℹ️ View Unchanged
|
Base automatically changed from
kevin/includes-arbitrary-correlation
to
kevin/includes
March 12, 2026 13:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/react-native/shopping-list/) showcasing three TanStack DB features:count()subqueries to compute per-list item counts;ListCardsubcomponents subscribe to child collections viauseLiveQuery()for reactive updatesstartOfflineExecutorfrom@tanstack/offline-transactions/react-nativepersistedCollectionOptionswithcreateReactNativeSQLitePersistence(op-sqlite) so data survives app restartsserver/index.ts) with in-memory storage and seed data for polling-based syncTest plan
cd examples/react-native/shopping-list && npx tsx server/index.tsnpx expo start --dev-client --clearnpx expo run:android🤖 Generated with Claude Code