Upgrade solidjs beta 19 by brenelz · Pull Request #7813 · TanStack/router

brenelz · 2026-07-14T00:19:31Z

No description provided.

Bumps solid-js, @solidjs/web, and babel-preset-solid from 2.0.0-beta.15 to 2.0.0-beta.16 across packages, examples, e2e apps, benchmarks, and the pnpm overrides in pnpm-workspace.yaml. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Bumps solid-js, @solidjs/web, and babel-preset-solid from 2.0.0-beta.16 to 2.0.0-beta.17 across packages, examples, e2e apps, and benchmarks. The scoped babel-preset-solid overrides in pnpm-workspace.yaml are removed instead of bumped: vite-plugin-solid@3.0.0-next.5 and @rsbuild/plugin-solid@2.0.0-beta.0 both declare '>=2.0.0-beta.0 <2.0.0-experimental.0', which resolves to the newest v2 beta on its own, while Solid 1.x consumers keep babel-preset-solid 1.x. A stale override here silently kept the beta.16 compiler (with its broken omitLastClosingTag marker handling) in the build pipeline. The @dom-expressions/* scope is added to minimumReleaseAgeExclude, covering the renamed compiler package (@dom-expressions/babel-plugin-jsx, formerly babel-plugin-jsx-dom-expressions). Two unrelated loose specs are pinned to their locked versions because re-resolving the lockfile pulled broken releases: @platformatic/flame 1.7.0 fails pnpm's trust-downgrade policy, and the nitro-nightly 'latest' tag depends on an unpublished h3 version. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

On the client, returning the loadPromise from MatchInner's pending branch keeps a live async source in the tree whenever a match is pending. Since Solid 2.0.0-beta.16, that routes every signal write into a transition hold for the rest of the flush, which breaks router-core's synchronous write-then-load flows: invalidate() on a notFound match never re-ran the loader, and writes to unrelated signals were held too. SSR keeps the suspension so the streaming engine waits for the match to settle; the client now renders just the pending component. Verified on beta.17: without this, "re-runs loaders that throw notFound() when invalidated via HMR filter" and "keeps rendering a route notFoundComponent when loader returns notFound() after invalidate" fail. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-14T00:19:38Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 351c5fb8-fc0a-4cae-8558-fb27732590d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch upgrade-solidjs-beta-16

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-07-14T00:20:03Z

View your CI Pipeline Execution ↗ for commit 8b7516c

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	12m 33s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	26s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-16 13:48:21 UTC

github-actions · 2026-07-14T00:20:52Z

🚀 Changeset Version Preview

6 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/solid-router`	2.0.0-beta.23 → 2.0.0-beta.24	Changeset
`@tanstack/solid-router-devtools`	2.0.0-beta.18 → 2.0.0-beta.19	Changeset
`@tanstack/solid-router-ssr-query`	2.0.0-beta.24 → 2.0.0-beta.25	Changeset
`@tanstack/solid-start`	2.0.0-beta.24 → 2.0.0-beta.25	Changeset
`@tanstack/solid-start-client`	2.0.0-beta.23 → 2.0.0-beta.24	Changeset
`@tanstack/solid-start-server`	2.0.0-beta.23 → 2.0.0-beta.24	Changeset

socket-security · 2026-07-14T00:21:35Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

codspeed-hq · 2026-07-14T00:34:03Z

Merging this PR will improve performance by 56%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
🆕 173 new benchmarks

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`ssr request loop (react)`	330.5 ms	77.9 ms	×4.2
⚡	Simulation	`client-side navigation loop (solid)`	72.6 ms	43.9 ms	+65.54%
⚡	Simulation	`ssr request loop (vue)`	420.3 ms	283.8 ms	+48.07%
⚡	Simulation	`ssr request loop (solid)`	174.6 ms	151.7 ms	+15.12%
⚡	Simulation	`client-side navigation loop (react)`	56.3 ms	50.3 ms	+11.87%
⚡	Simulation	`client-side navigation loop (vue)`	83 ms	77.1 ms	+7.64%
🆕	Simulation	`ssr not-found (vue)`	N/A	169.5 ms	N/A
🆕	Simulation	`ssr redirect (vue)`	N/A	68.3 ms	N/A
🆕	Simulation	`ssr head (vue)`	N/A	326.9 ms	N/A
🆕	Simulation	`ssr loaders (vue)`	N/A	136.9 ms	N/A
🆕	Simulation	`ssr selective (vue)`	N/A	139.9 ms	N/A
🆕	Simulation	`ssr server-fn GET (vue)`	N/A	74.5 ms	N/A
🆕	Simulation	`ssr server-fn POST (vue)`	N/A	71.4 ms	N/A
🆕	Simulation	`ssr server-route middleware (vue)`	N/A	63.3 ms	N/A
🆕	Simulation	`ssr server-route (vue)`	N/A	60.8 ms	N/A
🆕	Simulation	`ssr streaming deferred (vue)`	N/A	105.1 ms	N/A
🆕	Simulation	`ssr assets inline-css cdn (vue)`	N/A	188.5 ms	N/A
🆕	Simulation	`ssr assets linked-css control (vue)`	N/A	215.7 ms	N/A
🆕	Simulation	`ssr before-load chain (vue)`	N/A	184.4 ms	N/A
🆕	Simulation	`ssr control-flow error 500 (vue)`	N/A	197.8 ms	N/A
...	...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing upgrade-solidjs-beta-16 (8b7516c) with solid-router-v2-pre (67a9040)¹}

No successful run was found on solid-router-v2-pre (2bb318b) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

The lockfile entry for @rspack/binding@2.0.8 only listed the darwin-arm64 binding, so linux CI runners had no matching native binding and rspack fell back to a hoisted 2.0.0 binary, crashing the bundle-size benchmark with a core/binding version mismatch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

… suspension Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

github-actions · 2026-07-14T00:44:01Z

Bundle Size Benchmarks

Commit: 9959c1462cda
Measured at: 2026-07-16T13:36:48.577Z
Baseline source: history:0b178a79e2e8
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
`react-router.minimal`	87.37 KiB	+26 B (+0.03%)	87.24 KiB	273.88 KiB	75.99 KiB	▁██████▄▄▄▄█
`react-router.full`	91.10 KiB	+42 B (+0.05%)	90.96 KiB	285.78 KiB	79.15 KiB	▁██████▁▁▁▁█
`solid-router.minimal`	40.98 KiB	+5.45 KiB (+15.34%)	40.85 KiB	119.72 KiB	36.94 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-router.full`	45.93 KiB	+5.35 KiB (+13.18%)	45.81 KiB	134.95 KiB	41.35 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`vue-router.minimal`	53.07 KiB	+69 B (+0.13%)	52.94 KiB	150.12 KiB	47.70 KiB	▂██████▁▁▁▁█
`vue-router.full`	59.03 KiB	+99 B (+0.16%)	58.90 KiB	168.88 KiB	52.93 KiB	▅██████▁▁▁▁█
`react-start.minimal`	102.03 KiB	+41 B (+0.04%)	101.89 KiB	322.31 KiB	88.32 KiB	▁██████▁▁▁▁█
`react-start.deferred-hydration`	102.76 KiB	+40 B (+0.04%)	101.91 KiB	323.69 KiB	88.91 KiB	▁██████▁▁▁▁█
`react-start.full`	105.45 KiB	+87 B (+0.08%)	105.31 KiB	332.24 KiB	91.23 KiB	▄██████▁▁▁▁█
`react-start.rsbuild.minimal`	99.74 KiB	+64 B (+0.06%)	99.57 KiB	316.74 KiB	85.81 KiB	▃██████▁▁▁▁█
`react-start.rsbuild.minimal-iife`	100.14 KiB	+67 B (+0.07%)	99.98 KiB	317.67 KiB	86.21 KiB	▃██████▁▁▁▁█
`react-start.rsbuild.full`	102.96 KiB	+70 B (+0.07%)	102.79 KiB	326.79 KiB	88.60 KiB	▃██████▁▁▁▁█
`solid-start.minimal`	66.57 KiB	+16.96 KiB (+34.18%)	66.44 KiB	198.37 KiB	59.17 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-start.deferred-hydration`	70.42 KiB	+17.55 KiB (+33.20%)	66.94 KiB	207.10 KiB	62.79 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-start.full`	70.48 KiB	+15.06 KiB (+27.17%)	70.35 KiB	209.95 KiB	62.56 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`vue-start.minimal`	71.13 KiB	+104 B (+0.14%)	71.00 KiB	207.37 KiB	63.03 KiB	▇██████▁▁▁▁█
`vue-start.full`	75.13 KiB	+101 B (+0.13%)	75.00 KiB	220.01 KiB	66.37 KiB	▅██████▁▁▁▁█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

pkg-pr-new · 2026-07-14T00:45:45Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7813

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7813

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7813

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7813

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7813

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7813

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7813

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7813

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7813

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7813

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7813

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7813

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7813

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7813

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7813

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7813

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7813

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7813

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7813

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7813

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7813

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7813

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7813

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7813

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7813

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7813

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7813

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7813

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7813

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7813

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7813

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7813

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7813

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7813

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7813

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7813

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7813

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7813

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7813

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7813

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7813

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7813

commit: 8b7516c

…art-rscs The pinned nitro-nightly@4.0.0-20251010 self-imports 'nitro/runtime/meta', which under pnpm's isolated layout resolves to the hoisted nitro 3.x beta and crashes vite config loading. Mirrors upstream fix e65f0c8 (#7809). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…id to next.8 Bumps solid-js, @solidjs/web, and babel-preset-solid from 2.0.0-beta.17 to 2.0.0-beta.18 and vite-plugin-solid from 3.0.0-next.7 to 3.0.0-next.8 (which pins @dom-expressions/jsx-compiler to 0.50.0-next.21) across packages, examples, e2e apps, and benchmarks. vite-plugin-solid is added to minimumReleaseAgeExclude: Solid publishes plugin prereleases in lockstep with the runtime betas, often minutes before we bump, and pnpm's 24h release-age gate otherwise filters the new version with a misleading NO_MATCHING_VERSION error. Verified: solid-router unit tests (client + server modes), solid-start basic e2e (80 passed), solid-router basic-file-based e2e (120 passed), and all 17 bundle-size benchmark scenarios build cleanly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…stead of asserting a single entry vite-plugin-solid >= 3.0.0-next.6 emits a facade chunk for every dynamically imported project module during SSR client builds (to keep its own manifest lookups stable), and emitted chunks are flagged `isEntry` just like the configured entry. The start manifest capture plugin asserted the client bundle contains exactly one entry chunk, so every solid-start app failed to build with "multiple entries detected". The capture plugin now receives the resolved client entry path and picks the entry chunk whose facadeModuleId matches it; other entry-flagged chunks are treated as ordinary chunks. When no chunk matches, a single entry is still accepted as before, and the multiple-entries error now lists every entry chunk with its facade module to ease diagnosis. Verified with fresh package builds: previously failing memory-server solid benchmark targets, all 17 bundle-size scenarios, solid-start basic build + e2e (80 passed), react-start basic build, and the start-plugin-core unit suite (494 tests). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…n dev manifest test Fixes the type tests after startManifestPlugin gained a required getClientEntry option. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…odule instead of asserting a single entry" This reverts commit d0f4926.

next.10 ships the fix for the lazy facade entry reclassification under rolldown-vite (solidjs/vite-plugin-solid#269): assigning isEntry = false instead of deleting the property, so the reclassification actually propagates through rolldown's bundle proxies and downstream plugins no longer see every lazy facade chunk as an application entry. This is the proper replacement for the reverted start-plugin-core workaround (see a1ee163) — the strict single-entry assertion now holds again. Verified: e2e/solid-start/basic build + e2e suite (80 passed), solid-router test:unit client (814) + server (2) modes, start-plugin-core unit tests (486). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…-solid to 3.0.0-next.11 vite-plugin-solid 3.0.0-next.11 peer-requires solid-js and @solidjs/web >=2.0.0-beta.19, so the Solid v2 packages are bumped in lockstep across all workspace pins (packages, examples, e2e, benchmarks). Verified: e2e/solid-start/basic build succeeds — no "multiple entries detected" error from start-manifest-capture-client-build; solid-router test:unit client (814 passed) + server (2 passed) modes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

socket-security · 2026-07-16T09:49:01Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	babel-preset-solid@2.0.0-beta.18

View full report

…-solid to 3.0.0-next.11 [Self-Healing CI Rerun]

The prerender crawl runs inside `vite build` and SSRs /posts and every crawled /posts/$postId. The `import.meta.env.VITE_NODE_ENV === 'test'` switch to the local dummy server was inlined away at build time because Playwright only sets that env for the test-time webServer, never for the nx build target — so build-time SSR fetched the real jsonplaceholder.typicode.com from CI. When that public API stalled, the page never sent headers and the build died after undici's 5-minute headers timeout (UND_ERR_HEADERS_TIMEOUT). Fix, applied to the react/solid/vue basic apps alike: - Resolve the posts/users API base URL at request time from process.env (same pattern users.tsx already used) instead of build-time inlining, so the built app honors whatever dummy server the harness is running. - Add e2eStartDummyServerForBuild() to @tanstack/router-e2e-utils and call it from the apps' vite configs in prerender mode: it starts the dummy server on a free port for the lifetime of the build, exposes it via VITE_NODE_ENV/VITE_EXTERNAL_PORT, and unrefs everything so the build process can exit. Verified: nx run tanstack-solid-start-e2e-basic:build:vite:prerender passes (47 pages prerendered, dummy server used, tsc clean), prerendered posts/index.html contains the expected content, and the server bundle now keeps the runtime env check instead of a hardcoded external URL. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…-solid to 3.0.0-next.11 [Self-Healing CI Rerun]

nx-cloud

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

View detailed reasoning in Nx Cloud ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

CI still hit UND_ERR_HEADERS_TIMEOUT during build:vite:prerender after de2132a. The failure pattern (fetch logs print instantly, then a 5-minute stall) means the posts fetches still reached the real external API in that run: the dummy server resolves in milliseconds in-process, and a non-listening port would fail instantly with ECONNREFUSED. One way that can happen: e2eStartDummyServerForBuild() early-returned whenever VITE_EXTERNAL_PORT was already present in the environment, skipping both the server start AND setting VITE_NODE_ENV — leaving the runtime URL check pointing at jsonplaceholder. Guard on a globalThis flag instead and always set both env vars. Also, to make the next failure diagnosable and survivable: - fetchPost/fetchPosts (react/solid/vue basic) now log the base URL they fetch from, so CI output shows whether the dummy server was used. - prerender configs set retryCount: 2 / retryDelay: 1000 so a transient hang retries instead of failing the whole build. Verified: nx run tanstack-solid-start-e2e-basic:build:vite:prerender passes with "Fetching posts from http://localhost:<port>..." in the log and 47 pages prerendered. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

brenelz and others added 3 commits July 8, 2026 17:01

github-actions Bot added package: solid-router package: solid-start-client package: solid-start-server package: solid-start package: solid-router-devtools package: solid-router-ssr-query labels Jul 14, 2026

brenelz changed the title ~~Upgrade solidjs beta 16~~ Upgrade solidjs beta 17 Jul 14, 2026

birkskyum approved these changes Jul 14, 2026

View reviewed changes