Repository navigation
Add Stage 65 community website constructional suggestions - #91
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Record three verified contracts for the Pi-hole Compose password fallback, cleanup that removes stopped Tier 2 containers, and a non-interactive apt step in the weekly update. Co-authored-by: Sebastian Becker <Beckastian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds publishable Stage 65 website markdown under
suggestions/website/. The pages reuse the existing GitHub-native community path and record three defects checked on 2026-11-01 againstdev. They do not restate Stages 1–64 (open PRs #27–#90).WEBPASSWORDkeeps the quote characters in${PIHOLE_PASSWORD:-'SwissPiHole2024!'}. Compose v5.1.0 renders those quotes when the variable is unset or empty. The contract copies the AFFiNE${VAR:?}form../tu-vm.sh cleanuprunsdocker system prune -f, and a successful update runsdocker container prune -f. Both remove the stopped Tier 2 containersup -d --no-startcreated for the dashboard. Named volumes stay out of scope: this CLI'sdocker volume prunewithout--allonly removes anonymous volumes.tu-vm.sh update, which runsapt-get upgrade -ywithoutDEBIAN_FRONTENDor dpkg--force-confdef/--force-confold. dpkg 1.22.6's help saysconfdefstill prompts unless one of those flags is set. The weekly flock stays held while that question is open.No application code is changed. Historical files in
suggestions/stay the archive.Scope
Docs only. New files:
suggestions/website/index.mdsuggestions/website/pihole-webpassword-quote-contract.mdsuggestions/website/stopped-container-prune-contract.mdsuggestions/website/weekly-update-apt-prompt-contract.mdRelease notes (maintainers)
Documentation. Community suggestion contracts for Pi-hole admin password interpolation, cleanup that preserves stopped Compose containers, and a non-interactive apt step in
tu-vm.sh update.Security & RFC
.envvalues in repo or CI logs.The Pi-hole page names the published insecure default already present in
docker-compose.ymlandtu-vm.sh. No.envwas created.Verification
set -a; . ./env.example; set +a; ./scripts/pre-push-check.sh(passes; missing TLS and allowlist warnings are expected without runtime files)docker compose configfor unset, empty, and setPIHOLE_PASSWORD(quotes appear only on the unset and empty rows)docker container prune --helpanddocker volume prune --help(stopped containers;--allis required before named volumes)dpkg --force-helpandapt-get(8)-ywording.apt-get upgradewas not executed.git diff --checkclean./scripts/smoke-test.sh --livewas not run. Nginx was not started.