Skip to content

Add Stage 65 community website constructional suggestions - #91

Closed
cursor[bot] wants to merge 1 commit into
devfrom
cursor/suggestions-folder-structure-81d4
Closed

cursor[bot] wants to merge 1 commit into
devfrom
cursor/suggestions-folder-structure-81d4

Conversation

@cursor

@cursor cursor Bot commented Nov 1, 2026

Copy link
Copy Markdown

Summary

Adds publishable Stage 65 website markdown under suggestions/website/. The pages reuse the existing GitHub-native community path and record three defects checked on 2026-11-01 against dev. They do not restate Stages 1–64 (open PRs #27–#90).

  • Pi-hole WEBPASSWORD keeps the quote characters in ${PIHOLE_PASSWORD:-'SwissPiHole2024!'}. Compose v5.1.0 renders those quotes when the variable is unset or empty. The contract copies the AFFiNE ${VAR:?} form.
  • ./tu-vm.sh cleanup runs docker system prune -f, and a successful update runs docker container prune -f. Both remove the stopped Tier 2 containers up -d --no-start created for the dashboard. Named volumes stay out of scope: this CLI's docker volume prune without --all only removes anonymous volumes.
  • Weekly cron calls tu-vm.sh update, which runs apt-get upgrade -y without DEBIAN_FRONTEND or dpkg --force-confdef / --force-confold. dpkg 1.22.6's help says confdef still prompts unless one of those flags is set. The weekly flock stays held while that question is open.

No application code is changed. Historical files in suggestions/ stay the archive.

Scope

Docs only. New files:

  • suggestions/website/index.md
  • suggestions/website/pihole-webpassword-quote-contract.md
  • suggestions/website/stopped-container-prune-contract.md
  • suggestions/website/weekly-update-apt-prompt-contract.md

Release notes (maintainers)

Documentation. Community suggestion contracts for Pi-hole admin password interpolation, cleanup that preserves stopped Compose containers, and a non-interactive apt step in tu-vm.sh update.

Security & RFC

  • Does not expose secrets, tokens, or production .env values in repo or CI logs.
  • Control-plane / nginx allowlist behavior unchanged unless intentional and documented.
  • Breaking operational behavior called out in README or playbooks where operators would notice.

The Pi-hole page names the published insecure default already present in docker-compose.yml and tu-vm.sh. No .env was created.

Verification

  • set -a; . ./env.example; set +a; ./scripts/pre-push-check.sh (passes; missing TLS and allowlist warnings are expected without runtime files)
  • docker compose config for unset, empty, and set PIHOLE_PASSWORD (quotes appear only on the unset and empty rows)
  • docker container prune --help and docker volume prune --help (stopped containers; --all is required before named volumes)
  • dpkg --force-help and apt-get(8) -y wording. apt-get upgrade was not executed.
  • Frontmatter and relative links in the four new pages; git diff --check clean

./scripts/smoke-test.sh --live was not run. Nginx was not started.

Open in Web View Automation 

Record three verified contracts for the Pi-hole Compose password fallback, cleanup that removes stopped Tier 2 containers, and a non-interactive apt step in the weekly update.

Co-authored-by: Sebastian Becker <Beckastian@users.noreply.github.com>
@Beckastian Beckastian closed this Nov 13, 2026
@Beckastian
Beckastian deleted the cursor/suggestions-folder-structure-81d4 branch November 13, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants