Shortest coprime segment using sliding window technique#6296
Merged
Conversation
DomTr
requested review from
BamaCharanChhandogi,
DenizAltunkapan,
alxkm,
siriak,
vil02 and
yanglbme
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6296 +/- ##
============================================
+ Coverage 74.10% 74.14% +0.03%
- Complexity 5345 5359 +14
============================================
Files 677 678 +1
Lines 18639 18686 +47
Branches 3618 3625 +7
============================================
+ Hits 13812 13854 +42
- Misses 4272 4274 +2
- Partials 555 558 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
requested changes
Jun 17, 2025
DenizAltunkapan
left a comment
DenizAltunkapan
left a comment
Member
There was a problem hiding this comment.
please fix the failing build pipeline
Shaqlain03456
approved these changes
Jun 18, 2025
DenizAltunkapan
requested changes
Jun 18, 2025
…t segment itself. 2. Testcases have been adapted, a few new ones added.
vil02
pushed a commit
to vil02/Java
that referenced
this pull request
Jul 2, 2025
…s#6296) * Shortest coprime segment using sliding window technique * mvn checkstyle passes * gcd function reformatted * fixed typo in ShortestCoprimeSegment * 1. shortestCoprimeSegment now returns not the length, but the shortest segment itself. 2. Testcases have been adapted, a few new ones added. * clang formatted ShortestCoprimeSegmentTest.java code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java