Repository navigation
test: add white-box unit tests for Luhn.luhnCheck - #7641
Merged
DenizAltunkapan merged 2 commits intoOct 9, 2026
Merged
Conversation
Cover the loop (zero, one and many iterations), both outcomes of the `i % 2 == 0` and `temp > 9` decisions, boundary values (8 / 10 after doubling), valid and invalid checksums, input immutability and null input.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7641 +/- ##
============================================
+ Coverage 82.00% 82.04% +0.03%
- Complexity 8280 8285 +5
============================================
Files 840 840
Lines 25872 25872
Branches 5053 5053
============================================
+ Hits 21216 21226 +10
+ Misses 3866 3856 -10
Partials 790 790 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Infer reports NULLPTR_DEREFERENCE for passing null to luhnCheck on purpose. The method does not document null handling, so the case is removed.
datpp
marked this pull request as ready for review
October 9, 2026 09:02
datpp
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
October 9, 2026 09:02
DenizAltunkapan
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luhnhad no test class. This PR addsLuhnTestwith white-box tests forLuhn.luhnCheck(int[]).The method has one loop and two decisions (
i % 2 == 0,temp > 9). The tests cover:JaCoCo: 100% instruction and 100% branch coverage for
luhnCheck.clang-format -i --style=file path/to/your/file.java