Skip to content

fix(compute): tuple3/tuple4 pin typing#144

Open
digitalwannabe wants to merge 1 commit intoTheFuseLab:1.0from
digitalwannabe:1.0
Open

fix(compute): tuple3/tuple4 pin typing#144
digitalwannabe wants to merge 1 commit intoTheFuseLab:1.0from
digitalwannabe:1.0

Conversation

@digitalwannabe
Copy link

Description

Tuple3/Tuple4 Split had Tuple2 as input type
Tuple4 Join had Tuple3 as output type

Change Type

  • New shader node
  • New SDSL function
  • Shader modification
  • Core engine change (C#)
  • Help/documentation
  • [x ] Bug fix
  • Performance improvement
  • Refactoring

Affected Domains

  • Noise
  • SDF (Signed Distance Fields)
  • [x ] Compute
  • Domain (Raymarching)
  • Color
  • Transform
  • Texture
  • Geometry
  • Fluid
  • Other:

Breaking Changes

  • None
  • API changes (C# method signatures)
  • Shader signature changes (SDSL)
  • [x ] VL node changes (pins added/removed/renamed)
  • Behavior changes (same inputs, different outputs)

Migration Guide

Since these nodes don't work as expected at all without the fix I'm assuming they have not been used until now.

Testing

  • Tested with existing help patches
  • New help patch added
  • Existing help patch updated
  • [x ] Manual GPU output verification
  • Performance tested

Test Details

I am actively using the nodes in a compute system i am building, its working as expected...

Related Issues

Screenshots/Videos

Checklist

  • [x ] I have read CONTRIBUTING.md
  • [x ] I have followed the patterns in PATTERNS.md
  • [x ] My code follows the existing style
  • I have added documentation for new features
  • All existing help patches still work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant