Repository navigation
chore: enforce platform provided solver versions during build of the model w… - #2811
Merged
rsynek merged 1 commit intoNov 9, 2026
Merged
Conversation
mswiderski
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The snapshot validation test fails with released core versions, and stripping release-candidate suffixes before minimum-version validation can incorrectly accept an artifact below the required version.
2 open issues
What changed in this PR
This PR connects platform-provided solver version limits to model build validation through the Maven plugin and Quarkus extension.
Changes:
- Reads optional version bounds and snapshot policy from platform configuration and writes them to build properties.
- Adds build-time checks for minimum and maximum solver versions and disallowed snapshots.
- Adds property-propagation, version-comparison, and build-failure tests.
| File | Description |
|---|---|
service/tools/maven-plugin/src/test/java/ai/timefold/solver/tools/maven/ConfigureMojoTest.java |
Tests propagation of present and absent version settings. |
service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/ConfigureMojo.java |
Writes platform version settings to build properties. |
service/tools/maven-plugin/src/main/java/ai/timefold/solver/tools/maven/client/ConfigurationInfo.java |
Adds optional version bounds and snapshot policy fields. |
service/quarkus/deployment/src/test/java/ai/timefold/solver/service/quarkus/deployment/SolverVersionValidationTest.java |
Tests version bounds, ordering, and snapshot handling. |
service/quarkus/deployment/src/test/java/ai/timefold/solver/service/quarkus/deployment/SolverVersionValidationBuildTest.java |
Tests build rejection above the maximum version. |
service/quarkus/deployment/src/test/java/ai/timefold/solver/service/quarkus/deployment/SolverSnapshotValidationBuildTest.java |
Tests build rejection when snapshots are prohibited. |
service/quarkus/deployment/src/main/java/ai/timefold/solver/service/quarkus/deployment/TimefoldModelDescriptorProcessor.java |
Validates the solver version during model augmentation. |
service/quarkus/deployment/pom.xml |
Adds Maven Artifact for version comparison. |
Review effort: Balanced
mswiderski
force-pushed
the
minimal-solver-version-maven-plugin
branch
from
November 9, 2026 07:35
990b162 to
753c6d3
Compare
Copilot stopped reviewing on behalf of
mswiderski due to an error
November 9, 2026 07:36
mswiderski
force-pushed
the
minimal-solver-version-maven-plugin
branch
from
November 9, 2026 07:56
753c6d3 to
32c3923
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new solver-version restrictions can fail deployment builds, but the deployment guide lacks required documentation on limits, inclusive bounds, snapshot handling, and absent-property behavior.
2 open issues
3 resolved since last review
Review effort: Balanced
rsynek
approved these changes
Nov 9, 2026
rsynek
left a comment
rsynek
left a comment
Contributor
There was a problem hiding this comment.
Looks good; one comment inline for your consideration.
…hen maven plugin is used
mswiderski
force-pushed
the
minimal-solver-version-maven-plugin
branch
from
November 9, 2026 09:03
32c3923 to
35b4b0a
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new model-build checks lack required user-facing documentation for platform-supplied version limits, inclusive bounds, snapshot policy, and unrestricted behavior when settings are omitted.
2 open issues
1 resolved since last review
Review effort: Balanced
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hen maven plugin is used