Repository navigation
fix: show a merge request whose pipeline failed, was canceled or never ran as on you - #18
Merged
Merged
Conversation
TomyCesaille
marked this pull request as ready for review
October 29, 2026 09:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
GitLab (
prtop/forges/gitlab.py): onci_must_pass, the status comes fromhead_pipeline.statusin the merge request_hydratealready fetches. No extra call.failedreads as❌ CI failed,canceledandcancelingas🛑 CI canceled, and a missing pipeline as💤 no pipeline. All three are marked!.created,scheduledand the running statuses read as⏳ CI running, marked.. GitLab reports a pipeline that is still running asci_still_running, so these cover a pipeline about to start.manualorskipped, shows as❔ pipeline <status>, marked?, like any state prtop does not map.GitHub (
prtop/forges/github.py): it had the same gap. A blocked pull request whose required checks reportFAILUREorERRORnow reads as❌ CI failed, marked!.EXPECTED, a required check that has not reported yet, staysCI running: GitHub cannot tell a check about to start from one that never will.CI must passleaves the vocabulary (model.CI_MUST_PASS).❌keeps a single meaning, a run that failed, now in three scopes.test_a_glyph_never_carries_two_meanings_in_the_status_columnlistsmodel.CI_FAILEDbeside the two deploy states.examples/claude-code/commands/prs.mdtells an agent what to do with each new status, with theglabandghcalls. It reads the failed job's log, fixes what the change broke or retries a flaky job, retries a canceled pipeline, and starts a missing one.Docs: AGENTS.md's conventions ask every pull request that changes what a user sees or runs for its CHANGELOG.md line, under
[Unreleased], in the same pull request. Until now only CONTRIBUTING.md said so. CHANGELOG.md gets back the blank line after### Changed.