Skip to content

Issue 11 stats#13

Merged
Trosper3 merged 6 commits intomainfrom
issue-11-stats
Mar 31, 2026
Merged

Issue 11 stats#13
Trosper3 merged 6 commits intomainfrom
issue-11-stats

Conversation

@Pranaya-Kafle
Copy link
Copy Markdown
Collaborator

Changes Made:

  • Created calculate_job_stats function in app/modules/jobs/service.py to handle the data logic.
  • Added GET /jobs/stats route in app/modules/jobs/routes.py (currently using mock Adzuna data until the live API connection is built).
  • Created app/tests/test_stats.py to verify the math logic.

Copy link
Copy Markdown
Owner

@Trosper3 Trosper3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, really nice job man. It looks really good.

The only thing I could find that needs to be improved is in a coverage report. I noticed that stats/routes.py is only 62% covered. We could get that up much higher if we add an integration test that simulates a successful response. Remember to try to keep the unit and integration tests separate when you do this. Again, I really appreciate your hard work!

Let me know if you have any questions or want to work on it together.

@Pranaya-Kafle Pranaya-Kafle requested a review from Trosper3 March 30, 2026 22:27
@Pranaya-Kafle
Copy link
Copy Markdown
Collaborator Author

// added the unit test for empty responses, and added an integration test. Coverage is now at 100%.

Copy link
Copy Markdown
Owner

@Trosper3 Trosper3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice dude!

@Trosper3 Trosper3 merged commit a6553c2 into main Mar 31, 2026
@Trosper3 Trosper3 deleted the issue-11-stats branch March 31, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants