Merged
Conversation
added 5 commits
March 18, 2026 23:49
Trosper3
requested changes
Mar 29, 2026
Owner
Trosper3
left a comment
There was a problem hiding this comment.
Overall, really nice job man. It looks really good.
The only thing I could find that needs to be improved is in a coverage report. I noticed that stats/routes.py is only 62% covered. We could get that up much higher if we add an integration test that simulates a successful response. Remember to try to keep the unit and integration tests separate when you do this. Again, I really appreciate your hard work!
Let me know if you have any questions or want to work on it together.
Collaborator
Author
|
// added the unit test for empty responses, and added an integration test. Coverage is now at 100%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made: